Bug 35256 – HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[John Sullivan]

This is a followup to <http://trac.webkit.org/changeset/51602>.

With that patch, HTMLSelectElement::setSelectedIndexByUser() is now triggered by Safari's forms autofill code. Some pages run JS that resets various form elements when the selected Country changes. As of 51602, that JS was being run even when there is no change to a pop-up element, which does no good and causes trouble for autofill.

[John Sullivan]

Created attachment 49235 [details]
Patch to bail out of setSelectedIndexByUser when the new index matches the old one

[John Sullivan]

Fixed in <http://trac.webkit.org/changeset/55101>

[Eric Seidel (no email)]

Comment on attachment 49235 [details]
Patch to bail out of setSelectedIndexByUser when the new index matches the old one

Can't we write a manual test?  One which would simply alert() on the change?

[Eric Seidel (no email)]

:(  for lack of testing.

[John Sullivan]

A manual test would have to be dependent on a particular client, since setSelectedIndexByUser() is not called if the user brings up the pop-up menu and then dismisses it with the initially-selected item still selected. So that's more in the realm of testing the browser than testing WebCore, I think.