Bug 35254 - WebInspector should open docked or allow docking if the proposed host window is too small.
Summary: WebInspector should open docked or allow docking if the proposed host window ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-02-22 12:15 PST by Brady Eidson
Modified: 2010-02-22 17:13 PST (History)
1 user (show)

See Also:


Attachments
WebCore fix for attach, WebKitMac/WebKitWin fix for showWindow() (7.72 KB, patch)
2010-02-22 12:19 PST, Brady Eidson
timothy: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-02-22 12:15:20 PST
WebInspector should open docked or allow docking if the proposed host window is too small.

It appears we have code that tried to do this, but it never quite worked in the right place.

WebCore can prevent the attaching when the view is too small, but without refactoring, the individual WebKits will have to cut off the initial ::showWindow() attachment themselves.

Forthcoming is a patch that gives WebKits a utility method for this, and a fix for WebKitWin and WebKitMac.
Comment 1 Brady Eidson 2010-02-22 12:19:51 PST
Created attachment 49232 [details]
WebCore fix for attach, WebKitMac/WebKitWin fix for showWindow()
Comment 2 Brady Eidson 2010-02-22 15:10:51 PST
http://trac.webkit.org/changeset/55107
Comment 3 Brady Eidson 2010-02-22 15:11:33 PST
BTW, in radar as <rdar://problem/7248409>
Comment 4 Eric Seidel (no email) 2010-02-22 17:06:46 PST
I think this may have caused https://bugs.webkit.org/show_bug.cgi?id=35274
Comment 5 Brady Eidson 2010-02-22 17:13:12 PST
(In reply to comment #4)
> I think this may have caused https://bugs.webkit.org/show_bug.cgi?id=35274

Seems likely.

As I commented in r35274, the strong possibility is that Chromium has the web inspector enabled during layouttests, but attempts to dock it, and that is no longer allowed.

If that ends up being the case, then...  well, it seems bizarre to do that, and I don't know that we should support it without a good reason why it's necessary.