Bug 35254 – WebInspector should open docked or allow docking if the proposed host window is too small.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Brady Eidson]

WebInspector should open docked or allow docking if the proposed host window is too small.

It appears we have code that tried to do this, but it never quite worked in the right place.

WebCore can prevent the attaching when the view is too small, but without refactoring, the individual WebKits will have to cut off the initial ::showWindow() attachment themselves.

Forthcoming is a patch that gives WebKits a utility method for this, and a fix for WebKitWin and WebKitMac.

[Brady Eidson]

Created attachment 49232 [details]
WebCore fix for attach, WebKitMac/WebKitWin fix for showWindow()

[Brady Eidson]

http://trac.webkit.org/changeset/55107

[Brady Eidson]

BTW, in radar as <rdar://problem/7248409>

[Eric Seidel (no email)]

I think this may have caused https://bugs.webkit.org/show_bug.cgi?id=35274

[Brady Eidson]

(In reply to comment #4)
> I think this may have caused https://bugs.webkit.org/show_bug.cgi?id=35274

Seems likely.

As I commented in r35274, the strong possibility is that Chromium has the web inspector enabled during layouttests, but attempts to dock it, and that is no longer allowed.

If that ends up being the case, then...  well, it seems bizarre to do that, and I don't know that we should support it without a good reason why it's necessary.