RESOLVED FIXED 35252
Set but never used variables
https://bugs.webkit.org/show_bug.cgi?id=35252
Summary Set but never used variables
Laszlo Gombos
Reported 2010-02-22 11:50:26 PST
Produced by QtWebKit build on Symbian on r55086. "\webkit\JavaScriptCore\pcre\pcre_compile.cpp", line 582: Warning: #550-D: variable "tempptr" was set but never used const UChar* tempptr; ^ "\webkit\WebCore\css\cssfontselector.cpp", line 234: Warning: #550-D: variable "foundLocal" was set but never used bool foundLocal = false; ^ "\webkit\WebCore\css\cssparser.cpp", line 3410: Warning: #550-D: variable "currentValue" was set but never used CSSParserValue* currentValue; ^ "\webkit\WebCore\dom\node.cpp", line 2460: Warning: #550-D: variable "foundListener" was set but never used bool foundListener = false; ^ "\webkit\WebCore\editing\insertparagraphseparatorcommand.cpp", line 215: Warning: #550-D: variable "shouldApplyStyleAfterInsertion" was set but never used bool shouldApplyStyleAfterInsertion = true; ^ "\webkit\WebCore\html\datecomponents.cpp", line 395: Warning: #550-D: variable "ok" was set but never used bool ok; ^ "\webkit\WebCore\loader\textresourcedecoder.cpp", line 571: Warning: C2874W: len may be used before being set int len; ^ "\webkit\WebCore\loader\appcache\applicationcachestorage.cpp", line 174: Warning: #550-D: variable "result" was set but never used int result; ^ "\webkit\WebCore\page\eventhandler.cpp", line 1824: Warning: #550-D: variable "didSetLatchedNode" was set but never used bool didSetLatchedNode = false; ^ "\webkit\WebCore\page\animation\animationbase.cpp", line 1221: Warning: #550-D: variable "totalDuration" was set but never used double totalDuration = -1; ^ "\webkit\WebCore\platform\network\resourcehandle.cpp", line 37: Warning: #550-D : variable "WebCore::shouldForceContentSniffing" was set but never used static bool shouldForceContentSniffing; ^ "\webkit\WebCore\rendering\autotablelayout.cpp", line 67: Warning: #550-D: variable "last" was set but never used RenderTableCell* last = 0; ^ "\webkit\WebCore\rendering\autotablelayout.cpp", line 512: Warning: #550-D: variable "haveRelative" was set but never used bool haveRelative = false; ^ "\webkit\WebCore\rendering\renderblock.cpp", line 4092: Warning: #550-D: variable "previousLeaf" was set but never used RenderObject* previousLeaf = 0; ^ "\webkit\WebCore\rendering\renderlayer.cpp", line 1013: Warning: #550-D: variable "foundAncestor" was set but never used bool foundAncestor = false; ^ "\webkit\WebCore\svg\svguseelement.cpp", line 709: Warning: #550-D: variable "newChildPtr" was set but never used SVGElement* newChildPtr = 0; ^ "\webkit\WebCore\svg\svguseelement.cpp", line 770: Warning: #550-D: variable "newChildPtr" was set but never used SVGElement* newChildPtr = 0; ^ "\webkit\WebCore\svg\graphics\svgresourceclipper.cpp", line 91: Warning: #550-D: variable "heterogenousClipRules" was set but never used bool heterogenousClipRules = false; ^
Attachments
remove unused variables (11.32 KB, patch)
2010-05-28 14:40 PDT, Laszlo Gombos
no flags
Laszlo Gombos
Comment 1 2010-05-28 14:40:22 PDT
Created attachment 57384 [details] remove unused variables I think this make the code more readable. Some of the variables are used in debug mode I left those variables in-pace (as the compiler warnings were collected from a release build).
WebKit Commit Bot
Comment 2 2010-05-29 08:30:48 PDT
Comment on attachment 57384 [details] remove unused variables Clearing flags on attachment: 57384 Committed r60408: <http://trac.webkit.org/changeset/60408>
WebKit Commit Bot
Comment 3 2010-05-29 08:30:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.