Bug 35242 – Settings::setGeolocationEnabled and Settings::geolocationEnabled are redundant

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

Settings::setGeolocationEnabled and Settings::geolocationEnabled were added in http://trac.webkit.org/changeset/51660

They are not used in WebCore as an alternative method to enable Geolocation at runtime was added in http://trac.webkit.org/changeset/53406

These methods should be removed.

[Sam Weinig]

Isn't the RuntimeEnabled stuff v8/chromium specific?

[Steve Block]

> Isn't the RuntimeEnabled stuff v8/chromium specific?
Yes, RuntimeEnabledFeatures is currently used only by the V8 bindings.

[Jonathan Dixon]

FYI all usage of Settings::setGeolocationEnabled and WebSettings::setGeolocationEnabled were removed from Chromium in http://src.chromium.org/viewvc/chrome?view=rev&revision=39707 so from our side it's now fine to go ahead remove these methods from WebKit (Note they're not wired up to actually do anything anyway, as https://bugs.webkit.org/show_bug.cgi?id=33467 shows this was abandoned in favour of RuntimeEnabledFeatures)

[Steve Block]

Created attachment 49271 [details]
Patch

[Jeremy Orlow]

Comment on attachment 49271 [details]
Patch

assuming this really is dead code...  r=me

Have you svn blamed these lines to see who added them and why?

[Steve Block]

Comment on attachment 49271 [details]
Patch

> Have you svn blamed these lines to see who added them and why?
Yes, they were added by joth in http://trac.webkit.org/changeset/51660 as mentioned above

[WebKit Commit Bot]

Comment on attachment 49271 [details]
Patch

Clearing flags on attachment: 49271

Committed r55147: <http://trac.webkit.org/changeset/55147>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.