RESOLVED FIXED Bug 35230
Build fix for PluginView 
https://bugs.webkit.org/show_bug.cgi?id=35230
Summary Build fix for PluginView
Kwang Yul Seo
Reported 2010-02-22 00:38:42 PST
PluginView::keepAlive(NPP) is duplicated in PluginView.cpp and PluginViewNone.cpp, so it causes a link error.
Attachments
Patch (911 bytes, patch)
2010-02-22 00:42 PST, Kwang Yul Seo 		laszlo.gombos: review-
DetailsFormatted DiffDiff
hope this works (1.90 KB, patch)
2010-02-22 08:43 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-02-22 00:42:21 PST
Created attachment 49191 [details] Patch Remove the duplicated symbol.
WebKit Commit Bot
Comment 2 2010-02-22 07:46:32 PST
Comment on attachment 49191 [details] Patch Rejecting patch 49191 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: ility_version 1 -current_version 533.1 -o /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZN7WebCore10PluginView9keepAliveEP4_NPP", referenced from: __NPN_Evaluate in NP_jsobject.o ld: symbol(s) not found collect2: ld returned 1 exit status ** BUILD FAILED ** The following build commands failed: WebCore: Ld /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal i386 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/298800
Laszlo Gombos
Comment 3 2010-02-22 08:22:21 PST
Comment on attachment 49191 [details] Patch This patch breaks MAC 64 bit as PluginViewNone.cpp is used for that build.
Laszlo Gombos
Comment 4 2010-02-22 08:43:56 PST
Created attachment 49219 [details] hope this works This might not need a review but I'd like to the commit-bot to be involved in this.
Eric Seidel (no email)
Comment 5 2010-02-22 14:42:12 PST
Comment on attachment 49219 [details] hope this works You can always just cq+ patches and they'll go through the queue. The r+ part is only about setting the actual text of the "Reviewed by" line. Obviously the standard committer practices of what patches are allowed to be committed, etc. should be followed for any patch with the commit-queue the same as if you were committing it manually yourself. :)
WebKit Commit Bot
Comment 6 2010-02-23 00:58:57 PST
Comment on attachment 49219 [details] hope this works Clearing flags on attachment: 49219 Committed r55128: <http://trac.webkit.org/changeset/55128>
WebKit Commit Bot
Comment 7 2010-02-23 00:59:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.