Bug 35230 - Build fix for PluginView
Summary: Build fix for PluginView
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-02-22 00:38 PST by Kwang Yul Seo
Modified: 2010-02-23 00:59 PST (History)
1 user (show)

See Also:

Patch (911 bytes, patch)
2010-02-22 00:42 PST, Kwang Yul Seo
laszlo.gombos: review-
Details | Formatted Diff | Diff
hope this works (1.90 KB, patch)
2010-02-22 08:43 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-02-22 00:38:42 PST
PluginView::keepAlive(NPP) is duplicated in PluginView.cpp and PluginViewNone.cpp, so it causes a link error.
Comment 1 Kwang Yul Seo 2010-02-22 00:42:21 PST
Created attachment 49191 [details]

Remove the duplicated symbol.
Comment 2 WebKit Commit Bot 2010-02-22 07:46:32 PST
Comment on attachment 49191 [details]

Rejecting patch 49191 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1
Last 500 characters of output:
ility_version 1 -current_version 533.1 -o /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore
Undefined symbols:
  "__ZN7WebCore10PluginView9keepAliveEP4_NPP", referenced from:
      __NPN_Evaluate in NP_jsobject.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

The following build commands failed:
	Ld /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal i386
(1 failure)

Full output: http://webkit-commit-queue.appspot.com/results/298800
Comment 3 Laszlo Gombos 2010-02-22 08:22:21 PST
Comment on attachment 49191 [details]

This patch breaks MAC 64 bit as PluginViewNone.cpp is used for that build.
Comment 4 Laszlo Gombos 2010-02-22 08:43:56 PST
Created attachment 49219 [details]
hope this works

This might not need a review but I'd like to the commit-bot to be involved in this.
Comment 5 Eric Seidel (no email) 2010-02-22 14:42:12 PST
Comment on attachment 49219 [details]
hope this works

You can always just cq+ patches and they'll go through the queue.  The r+ part is only about setting the actual text of the "Reviewed by" line.  Obviously the standard committer practices of what patches are allowed to be committed, etc. should be followed for any patch with the commit-queue the same as if you were committing it manually yourself. :)
Comment 6 WebKit Commit Bot 2010-02-23 00:58:57 PST
Comment on attachment 49219 [details]
hope this works

Clearing flags on attachment: 49219

Committed r55128: <http://trac.webkit.org/changeset/55128>
Comment 7 WebKit Commit Bot 2010-02-23 00:59:01 PST
All reviewed patches have been landed.  Closing bug.