Bug 35228 - [Gtk] Implement layoutTestController.numberOfPages
Summary: [Gtk] Implement layoutTestController.numberOfPages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-21 23:29 PST by Shinichiro Hamaji
Modified: 2010-02-23 04:43 PST (History)
6 users (show)

See Also:


Attachments
Patch v1 (5.01 KB, patch)
2010-02-21 23:30 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-02-21 23:29:59 PST
This was added in Bug 34699.
Comment 1 Shinichiro Hamaji 2010-02-21 23:30:58 PST
Created attachment 49184 [details]
Patch v1
Comment 2 WebKit Review Bot 2010-02-21 23:36:20 PST
Attachment 49184 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59:  webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/webkit/webkitwebframe.cpp:879:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Shinichiro Hamaji 2010-02-22 00:08:01 PST
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: 
> webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in
> your identifier names.  [readability/naming] [4]
> WebKit/gtk/webkit/webkitwebframe.cpp:879:  Use 0 instead of NULL. 
> [readability/null] [5]
> Total errors found: 2 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Ah, I forgot to fix this false alarms. Filed Bug 35229 and submitted a patch.
Comment 4 Eric Seidel (no email) 2010-02-22 14:39:46 PST
Comment on attachment 49184 [details]
Patch v1

Hot damn!
Comment 5 Shinichiro Hamaji 2010-02-23 04:43:32 PST
Comment on attachment 49184 [details]
Patch v1

Clearing flags on attachment: 49184

Committed r55144: <http://trac.webkit.org/changeset/55144>
Comment 6 Shinichiro Hamaji 2010-02-23 04:43:41 PST
All reviewed patches have been landed.  Closing bug.