Cache JavaScript wrappers inline in DOM nodes

[Maciej Stachowiak]

Cache JavaScript wrappers inline in DOM nodes

[Maciej Stachowiak]

Created attachment 49181 [details]
Patch

[Darin Adler]

Comment on attachment 49181 [details]
Patch

>  void forgetDOMObject(DOMObject* wrapper, void* objectHandle)
>  {
> +    
>      JSC::JSGlobalData* globalData = Heap::heap(wrapper)->globalData();

No need for this added blank line.

> -    JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Document*, Node*);
> +    JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Node*);

This is defined in JSNodeCustom.h instead of this header. Why?

> +    inline DOMObjectWrapperMap& DOMObjectWrapperMapFor(JSC::ExecState* exec)
> +    {
> +        return currentWorld(exec)->m_wrappers;
> +    }

In the past we have lowercased even acronyms like DOM here at the start of a function name. Maybe there's some way to dodge the issue.

r=me

[WebKit Review Bot]

Attachment 49181 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/297608

[WebKit Review Bot]

Attachment 49181 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/298397

[Maciej Stachowiak]

Committed r55074: <http://trac.webkit.org/changeset/55074>

[Maciej Stachowiak]

Reverted my change; it caused some breakage.

[Maciej Stachowiak]

Created attachment 49461 [details]
Patch

[Oliver Hunt]

Comment on attachment 49461 [details]
Patch

r=me

[WebKit Review Bot]

Attachment 49461 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/309288

[WebKit Review Bot]

Attachment 49461 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/308324

[Maciej Stachowiak]

Committed r55215: <http://trac.webkit.org/changeset/55215>