WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 72863
35208
webkit-patch upload fails to upload large patches but does not report an error
https://bugs.webkit.org/show_bug.cgi?id=35208
Summary
webkit-patch upload fails to upload large patches but does not report an error
Maciej Stachowiak
Reported
2010-02-21 00:47:44 PST
If a patch is over the 2M patch limit on bugs.webkit.org, webkit-patch upload will fail to upload it but will not report an error. Instead it appears to succeed.
https://bugs.webkit.org/show_bug.cgi?id=35206
has an example of such a patch.
Attachments
Add attachment
proposed patch, testcase, etc.
Adrienne Walker
Comment 1
2011-04-18 18:58:36 PDT
***
Bug 58857
has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 2
2011-04-18 19:03:57 PDT
Sad times. We should look at the bugzilla error code I guess. I think we have similar trouble with misspelled CCs.
Eric Seidel (no email)
Comment 3
2011-04-18 19:19:54 PDT
This is very similar to
bug 31760
. I suspect that the two places we need to check (and yell loudly) are:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py#L52
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/postdiff.py#L48
Possibly even returning or at least checking the result of browser.submit() here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py#L483
Eric Seidel (no email)
Comment 4
2012-02-03 11:41:37 PST
Duping this against
bug 72863
since there has been more activity there. *** This bug has been marked as a duplicate of
bug 72863
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug