WebCore/html/DateComponents.cpp: In function ‘bool WebCore::beforeGregorianStartDate(int, int, int)’: WebCore/html/DateComponents.cpp:148: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/html/DateComponents.cpp:149: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/plugins/PluginDatabase.cpp: In member function ‘WebCore::PluginPackage* WebCore::PluginDatabase::findPlugin(const WebCore::KURL&, WebCore::String&)’: WebCore/plugins/PluginDatabase.cpp:261: warning: suggest parentheses around assignment used as truth value
Created attachment 49137 [details] proposed patch
Comment on attachment 49137 [details] proposed patch Clearing flags on attachment: 49137 Committed r55058: <http://trac.webkit.org/changeset/55058>
All reviewed patches have been landed. Closing bug.
Reopen as I found one more of these. WebCore/wml/WMLVariables.cpp: In function 'WebCore::String WebCore::substituteVariableReferences(const WebCore::String&, WebCore::Document*, WebCore::WMLVariableEscapingMode)': WebCore/wml/WMLVariables.cpp:254: warning: suggest parentheses around assignment used as truth value I'm somewhat surprised that these warnings do not show up/disabled for other ports.
Created attachment 49213 [details] fix for WML code
Comment on attachment 49213 [details] fix for WML code Clearing flags on attachment: 49213 Committed r55087: <http://trac.webkit.org/changeset/55087>