Bug 35197 - Fix compiler warning "suggest parentheses around"
Summary: Fix compiler warning "suggest parentheses around"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-20 14:29 PST by Laszlo Gombos
Modified: 2010-02-22 09:25 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (2.12 KB, patch)
2010-02-20 15:45 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
fix for WML code (1.32 KB, patch)
2010-02-22 06:50 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-02-20 14:29:10 PST 
WebCore/html/DateComponents.cpp: In function ‘bool WebCore::beforeGregorianStartDate(int, int, int)’:
WebCore/html/DateComponents.cpp:148: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/html/DateComponents.cpp:149: warning: suggest parentheses around ‘&&’ within ‘||’
WebCore/plugins/PluginDatabase.cpp: In member function ‘WebCore::PluginPackage* WebCore::PluginDatabase::findPlugin(const WebCore::KURL&, WebCore::String&)’:
WebCore/plugins/PluginDatabase.cpp:261: warning: suggest parentheses around assignment used as truth value
Comment 1 Laszlo Gombos 2010-02-20 15:45:43 PST 
Created attachment 49137 [details]
proposed patch
Comment 2 WebKit Commit Bot 2010-02-20 21:22:48 PST 
Comment on attachment 49137 [details]
proposed patch

Clearing flags on attachment: 49137

Committed r55058: <http://trac.webkit.org/changeset/55058>
Comment 3 WebKit Commit Bot 2010-02-20 21:22:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Laszlo Gombos 2010-02-22 06:32:57 PST 
Reopen as I found one more of these. 

WebCore/wml/WMLVariables.cpp: In function 'WebCore::String WebCore::substituteVariableReferences(const WebCore::String&, WebCore::Document*, WebCore::WMLVariableEscapingMode)':
WebCore/wml/WMLVariables.cpp:254: warning: suggest parentheses around assignment used as truth value

I'm somewhat surprised that these warnings do not show up/disabled for other ports.
Comment 5 Laszlo Gombos 2010-02-22 06:50:17 PST 
Created attachment 49213 [details]
fix for WML code
Comment 6 WebKit Commit Bot 2010-02-22 09:25:41 PST 
Comment on attachment 49213 [details]
fix for WML code

Clearing flags on attachment: 49213

Committed r55087: <http://trac.webkit.org/changeset/55087>
Comment 7 WebKit Commit Bot 2010-02-22 09:25:45 PST 
All reviewed patches have been landed.  Closing bug.