Bug 35192 - Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
Summary: Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's vis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-20 06:30 PST by Pavel Feldman
Modified: 2010-02-20 07:40 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed fix. (1.89 KB, patch)
2010-02-20 06:37 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-02-20 06:30:38 PST 
1. Visit http://v8.googlecode.com/svn/data/benchmarks/v5/run.html
2. Set breakpoint in richards.js, line ~50
3. Reload the page

When you stop on a breakpoint, one in two times you will see two files (base.js and richards.js) rendered on top of each other. The reason is that when resource panel is re-creating a view from Other to Scripts, it manually hides last one, shows new one and that fools the ScriptsPanel's visibleView logic.

I will provide a small fix right now, but I think we should get rid of view re-creation. Now that we have two tabs in resourceView we can make its contents pluggable.
Comment 1 Pavel Feldman 2010-02-20 06:37:30 PST 
Created attachment 49124 [details]
[PATCH] Proposed fix.
Comment 2 Timothy Hatcher 2010-02-20 06:49:00 PST 
Comment on attachment 49124 [details]
[PATCH] Proposed fix.

Pluggable sounds good. Might this fix bug 28799?
Comment 3 Pavel Feldman 2010-02-20 06:52:24 PST 
(In reply to comment #2)
> (From update of attachment 49124 [details])
> Pluggable sounds good. Might this fix bug 28799?

Does not address 28799.
Comment 4 WebKit Commit Bot 2010-02-20 07:40:08 PST 
Comment on attachment 49124 [details]
[PATCH] Proposed fix.

Clearing flags on attachment: 49124

Committed r55052: <http://trac.webkit.org/changeset/55052>
Comment 5 WebKit Commit Bot 2010-02-20 07:40:13 PST 
All reviewed patches have been landed.  Closing bug.