RESOLVED FIXED 35192
Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
https://bugs.webkit.org/show_bug.cgi?id=35192
Summary Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's vis...
Pavel Feldman
Reported 2010-02-20 06:30:38 PST
1. Visit http://v8.googlecode.com/svn/data/benchmarks/v5/run.html 2. Set breakpoint in richards.js, line ~50 3. Reload the page When you stop on a breakpoint, one in two times you will see two files (base.js and richards.js) rendered on top of each other. The reason is that when resource panel is re-creating a view from Other to Scripts, it manually hides last one, shows new one and that fools the ScriptsPanel's visibleView logic. I will provide a small fix right now, but I think we should get rid of view re-creation. Now that we have two tabs in resourceView we can make its contents pluggable.
Attachments
[PATCH] Proposed fix. (1.89 KB, patch)
2010-02-20 06:37 PST, Pavel Feldman
no flags
Pavel Feldman
Comment 1 2010-02-20 06:37:30 PST
Created attachment 49124 [details] [PATCH] Proposed fix.
Timothy Hatcher
Comment 2 2010-02-20 06:49:00 PST
Comment on attachment 49124 [details] [PATCH] Proposed fix. Pluggable sounds good. Might this fix bug 28799?
Pavel Feldman
Comment 3 2010-02-20 06:52:24 PST
(In reply to comment #2) > (From update of attachment 49124 [details]) > Pluggable sounds good. Might this fix bug 28799? Does not address 28799.
WebKit Commit Bot
Comment 4 2010-02-20 07:40:08 PST
Comment on attachment 49124 [details] [PATCH] Proposed fix. Clearing flags on attachment: 49124 Committed r55052: <http://trac.webkit.org/changeset/55052>
WebKit Commit Bot
Comment 5 2010-02-20 07:40:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.