Bug 35187 – Web Inspector: can resize the main window to be smaller than the minimum docked height

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

Resizign the main window while docked can cause the Inspector to become smaller than the allowed minimum docked height.

We should undock when this happens.

[Juan C. Montemayor E]

Created attachment 58598 [details]
[PATCH] proposed patch v0

Docked Web inspector will automatically de-attach if the window gets too small.

Known Issues --
    • When docked, Web Inspector changes its height as the browser window is made smaller.
        • This causes the Web Inspector to be de-attached at different window sizes, depending on whether it was dragged beforehand or not. 
    • Is the name "checkDockedWindowSize( )" descriptive enough?

[Pavel Feldman]

Comment on attachment 58598 [details]
[PATCH] proposed patch v0

This is an arguable change since resizing window to be smaller than minimum and restoring its original size would leave inspector undocked. In fact, I don't see anything critical in having inspector less than 250 pixels in height. We just need to make sure that inspector toolbar is visible so that the user was not confused.

On the technical side of the change, I'd rather track inspected window size from within native code. Front-end code should not be responsible for the embedder's window size policy.

[Chris Chiera]

Created attachment 125191 [details]
Shows how Chrome does it properly, and how Safari hides the inspector incorrectly.

I'm not sure why in the world you would want the inspector to undock when shrinking. It should simply let you shrink is high as the inspector is just like Chrome does however the bug is that it lets you shrink past that amount. I've attached a screenshot since the reviewer I'm not sure fully understands the issue.