We should move the text caret drawing code in SelectionController::paintCaret into RenderTheme so that platforms can optionally draw the caret with respect to their theme.
Created attachment 49110 [details] Patch No functionality was changes so no tests are included in this patch.
Comment on attachment 49110 [details] Patch What would that mean? Do RIM devices not have a caret?
(In reply to comment #2) > (From update of attachment 49110 [details]) > What would that mean? Do RIM devices not have a caret? RIM devices have a caret. It is painted using the OS theme colors.
Comment on attachment 49110 [details] Patch Looking into this proposal some more.
Created attachment 50233 [details] Patch Updated patch following the landing of the patch for bug #34819 in changeset 55669 <http://trac.webkit.org/changeset/55669>. Also, moved repaintCaret code into a similar RenderTheme method.
Attachment 50233 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/editing/SelectionController.cpp:1022: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50234 [details] Patch Fixed style error.
Comment on attachment 50234 [details] Patch Is defaultTheme() really correct? I thought Qt had the notion of Page-specific themes.
Created attachment 50417 [details] Patch Updated patch to use the page-specific theme.
Comment on attachment 50417 [details] Patch So I get why you might want the theme to paint the caret, but what is the point of a repaint method being in the theme? I don't understand this part.
Comment on attachment 50417 [details] Patch Will look into alternative to repaintCaret method.