Bug 35172 - [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Summary: [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup cli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 13:30 PST by James Hawkins
Modified: 2010-02-19 14:51 PST (History)
2 users (show)

See Also:

Attachments
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup (2.04 KB, patch)
2010-02-19 13:32 PST, James Hawkins 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2010-02-19 13:30:53 PST 
This fixes a crash when the AutoFill suggestions popup is shown and the user deletes enough characters so that the popup hides itself.  Patch will follow.
Comment 1 James Hawkins 2010-02-19 13:32:11 PST 
Created attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Comment 2 Eric Seidel (no email) 2010-02-19 14:17:12 PST 
Comment on attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup

What other popups (non-autocomplete) are we using?  Some sort of grammar/spelling?
Comment 3 James Hawkins 2010-02-19 14:18:46 PST 
The AutoFill popup is the other popup.  It behaves a bit differently than the Autocomplete popup.
Comment 4 WebKit Commit Bot 2010-02-19 14:51:00 PST 
Comment on attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup

Clearing flags on attachment: 49102

Committed r55032: <http://trac.webkit.org/changeset/55032>
Comment 5 WebKit Commit Bot 2010-02-19 14:51:04 PST 
All reviewed patches have been landed.  Closing bug.