Bug 35171 - [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Summary: [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocom...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 13:24 PST by James Hawkins
Modified: 2010-02-19 14:35 PST (History)
4 users (show)

See Also:


Attachments
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function (2.86 KB, patch)
2010-02-19 13:26 PST, James Hawkins
no flags Details | Formatted Diff | Diff
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] (3.02 KB, patch)
2010-02-19 13:35 PST, James Hawkins
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2010-02-19 13:24:33 PST
Now that there are two Suggestion popup clients, AutoFill and Autocomplete, this method should be renamed to properly reflect the purpose of the function.  Patch will follow.
Comment 1 James Hawkins 2010-02-19 13:26:36 PST
Created attachment 49100 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Comment 2 WebKit Review Bot 2010-02-19 13:29:56 PST
Attachment 49100 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/288835
Comment 3 James Hawkins 2010-02-19 13:35:29 PST
Created attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

It helps if you actually change the function declaration.
Comment 4 Eric Seidel (no email) 2010-02-19 14:16:27 PST
Comment on attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

OK.
Comment 5 WebKit Commit Bot 2010-02-19 14:35:01 PST
Comment on attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

Clearing flags on attachment: 49103

Committed r55031: <http://trac.webkit.org/changeset/55031>
Comment 6 WebKit Commit Bot 2010-02-19 14:35:05 PST
All reviewed patches have been landed.  Closing bug.