Bug 35169 - [Gtk] Webkit crashes when using orca
Summary: [Gtk] Webkit crashes when using orca
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 25531
  Show dependency tree / graph
 
Reported: 2010-02-19 12:08 PST by José Millán Soto
Modified: 2010-02-23 00:10 PST (History)
3 users (show)

See Also:

Attachments
Check if end selection node is null (1.80 KB, patch)
2010-02-19 12:17 PST, José Millán Soto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description José Millán Soto 2010-02-19 12:08:08 PST 
As commented in https://bugs.webkit.org/show_bug.cgi?id=34463#c5 , webkit_accessible_text_get_caret_offset crashes when Orca is open.
To reproduce enter in any webpage and press tab until WebKit crashes.
Comment 1 José Millán Soto 2010-02-19 12:17:29 PST 
Created attachment 49099 [details]
Check if end selection node is null

This patch makes webkit_accessible_text_get_caret_offset check if end selection node is null, avoiding crashing.
Comment 2 Eric Seidel (no email) 2010-02-22 14:18:02 PST 
Comment on attachment 49099 [details]
Check if end selection node is null

I think this makes sense.
Comment 3 WebKit Commit Bot 2010-02-23 00:09:59 PST 
Comment on attachment 49099 [details]
Check if end selection node is null

Clearing flags on attachment: 49099

Committed r55124: <http://trac.webkit.org/changeset/55124>
Comment 4 WebKit Commit Bot 2010-02-23 00:10:08 PST 
All reviewed patches have been landed.  Closing bug.