Bug 35166 - [V8] Worker crashes due to r54972
Summary: [V8] Worker crashes due to r54972
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 10:39 PST by Nate Chapin
Modified: 2010-02-19 11:42 PST (History)
1 user (show)

See Also:


Attachments
patch (1.25 KB, patch)
2010-02-19 10:51 PST, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-02-19 10:39:44 PST
I didn't properly test the worker-related changes in the final version of r54972, and I screwed up unwrapping global objects when we're in a WorkerContext.

Patch momentarily.
Comment 1 Nate Chapin 2010-02-19 10:51:28 PST
Created attachment 49092 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-02-19 10:53:14 PST
Comment on attachment 49092 [details]
patch

ok.
Comment 3 Nate Chapin 2010-02-19 11:26:29 PST
http://trac.webkit.org/changeset/55023
Comment 4 Alexey Proskuryakov 2010-02-19 11:33:33 PST
Is this covered by existing regression tests?
Comment 5 Nate Chapin 2010-02-19 11:42:07 PST
(In reply to comment #4)
> Is this covered by existing regression tests?

Yes, but unfortunately, most (all?) of the tests that cover v8-related worker code are run under a full build of chromium, so problems didn't show up in any buildbots until chromium tried to merge passed r54972.

I thought I had run those tests locally prior to committing r54972, but apparently I hadn't.  Mea culpa.