Bug 35165 - plugins/set-status.html fails on Windows bot
Summary: plugins/set-status.html fails on Windows bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 10:27 PST by Alexey Proskuryakov
Modified: 2010-02-19 11:00 PST (History)
0 users

See Also:

Attachments
proposed fix (3.23 KB, patch)
2010-02-19 10:56 PST, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-02-19 10:27:56 PST 
http://build.webkit.org/results/Windows%20Release%20%28Tests%29/r55012%20%289239%29/plugins/set-status-pretty-diff.html

This is a pre-existing difference between Mac and Windows that's uncovered by this new test - Mac ignores null messages in NPN_SetMessage, while Windows treats them as empty ones.

Mac Firefox sets status to "Done" when message is null - and since we don't say "Done" after finishing the load, the closest equivalent is an empty status.
Comment 1 Alexey Proskuryakov 2010-02-19 10:56:44 PST 
Created attachment 49095 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2010-02-19 11:00:04 PST 
Committed <http://trac.webkit.org/changeset/55021>.