There are missing features (like animated flip) after the integration between QtLauncher and QGVLauncher. Also, QGVLauncher stills available on the WebKit source and should be removed once all features have been merged.
Created attachment 49088 [details] Add animated flip to QtLauncher - a missing feature The code is strongly based on the previous QGVLauncher.
Created attachment 49089 [details] Remove QGVLauncher from WebKit's source tree
Attachment 49088 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/QtLauncher/webview.cpp:52: Declaration has space between type name and * in QStateMachine *machine [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:53: Declaration has space between type name and * in QState *s0 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:56: Declaration has space between type name and * in QState *s1 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:59: Declaration has space between type name and * in QAbstractTransition *t1 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:60: Declaration has space between type name and * in QPropertyAnimation *yRotationAnim [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:64: Declaration has space between type name and * in QState *s2 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:68: Declaration has space between type name and * in QAbstractTransition *t2 [whitespace/declaration] [3] Total errors found: 7 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 49089 [details] Remove QGVLauncher from WebKit's source tree It seems that the clone feature is still not supported. I think this is important for testing the ability to have two views for the same QGraphicsWebView.
Comment on attachment 49088 [details] Add animated flip to QtLauncher - a missing feature Please fix the position of the *
Created attachment 49097 [details] Add animated flip to QtLauncher - v2
Comment on attachment 49097 [details] Add animated flip to QtLauncher - v2 Clearing flags on attachment: 49097 Committed r55025: <http://trac.webkit.org/changeset/55025>
All reviewed patches have been landed. Closing bug.