RESOLVED FIXED Bug 35161
[Qt] Need a final integration between QtLauncher and QGVLauncher 
https://bugs.webkit.org/show_bug.cgi?id=35161
Summary [Qt] Need a final integration between QtLauncher and QGVLauncher
Jesus Sanchez-Palencia
Reported 2010-02-19 09:28:24 PST
There are missing features (like animated flip) after the integration between QtLauncher and QGVLauncher. Also, QGVLauncher stills available on the WebKit source and should be removed once all features have been merged.
Attachments
Add animated flip to QtLauncher - a missing feature (8.11 KB, patch)
2010-02-19 10:29 PST, Jesus Sanchez-Palencia 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
Remove QGVLauncher from WebKit's source tree (19.96 KB, patch)
2010-02-19 10:30 PST, Jesus Sanchez-Palencia 		kenneth: review-
DetailsFormatted DiffDiff
Add animated flip to QtLauncher - v2 (8.11 KB, patch)
2010-02-19 11:20 PST, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2010-02-19 10:29:22 PST
Created attachment 49088 [details] Add animated flip to QtLauncher - a missing feature The code is strongly based on the previous QGVLauncher.
Jesus Sanchez-Palencia
Comment 2 2010-02-19 10:30:05 PST
Created attachment 49089 [details] Remove QGVLauncher from WebKit's source tree
WebKit Review Bot
Comment 3 2010-02-19 10:34:35 PST
Attachment 49088 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/QtLauncher/webview.cpp:52: Declaration has space between type name and * in QStateMachine *machine [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:53: Declaration has space between type name and * in QState *s0 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:56: Declaration has space between type name and * in QState *s1 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:59: Declaration has space between type name and * in QAbstractTransition *t1 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:60: Declaration has space between type name and * in QPropertyAnimation *yRotationAnim [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:64: Declaration has space between type name and * in QState *s2 [whitespace/declaration] [3] WebKitTools/QtLauncher/webview.cpp:68: Declaration has space between type name and * in QAbstractTransition *t2 [whitespace/declaration] [3] Total errors found: 7 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Rohde Christiansen
Comment 4 2010-02-19 10:53:14 PST
Comment on attachment 49089 [details] Remove QGVLauncher from WebKit's source tree It seems that the clone feature is still not supported. I think this is important for testing the ability to have two views for the same QGraphicsWebView.
Kenneth Rohde Christiansen
Comment 5 2010-02-19 10:54:16 PST
Comment on attachment 49088 [details] Add animated flip to QtLauncher - a missing feature Please fix the position of the *
Jesus Sanchez-Palencia
Comment 6 2010-02-19 11:20:27 PST
Created attachment 49097 [details] Add animated flip to QtLauncher - v2
WebKit Commit Bot
Comment 7 2010-02-19 11:47:05 PST
Comment on attachment 49097 [details] Add animated flip to QtLauncher - v2 Clearing flags on attachment: 49097 Committed r55025: <http://trac.webkit.org/changeset/55025>
WebKit Commit Bot
Comment 8 2010-02-19 11:47:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.