RESOLVED FIXED Bug 35159
[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add results for passing new tests 
https://bugs.webkit.org/show_bug.cgi?id=35159
Summary [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add re...
Andras Becsi
Reported 2010-02-19 08:43:34 PST
EventSender did not implement textZoomIn() and textZoomOut() and so some new tests failed. Add expected files for these passing tests and skip the ones Which are in the Skiplist. The differences to the Mac results are only due to SVG path dumping implementation differences and font size differences.
Attachments
proposed patch (28.16 KB, patch)
2010-02-19 08:53 PST, Andras Becsi 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-02-19 08:53:18 PST
Created attachment 49082 [details] proposed patch
Antonio Gomes
Comment 2 2010-02-19 08:57:03 PST
LGTM
Kenneth Rohde Christiansen
Comment 3 2010-02-19 08:58:39 PST
Comment on attachment 49082 [details] proposed patch Looks good, but some comments > + [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results > + for passing new tests and unskip the passing ones from the Skiplist. It is called Skipped, not Skiplist > + QWebFrame* frame = m_page->mainFrame(); > + if (frame) > + frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP); > +} Why not do if (QWebFrame* frame = m_page->mainFrame()) frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP); ?
Andras Becsi
Comment 4 2010-02-19 09:15:24 PST
Comment on attachment 49082 [details] proposed patch Updated patch committed in r55019. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.