Bug 35159 - [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add results for passing new tests
Summary: [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-02-19 08:43 PST by Andras Becsi
Modified: 2010-02-19 09:15 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (28.16 KB, patch)
2010-02-19 08:53 PST, Andras Becsi
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-02-19 08:43:34 PST
EventSender did not implement textZoomIn() and textZoomOut() and so some new tests failed. Add expected files for these passing tests and skip the ones Which are in the Skiplist.
The differences to the Mac results are only due to SVG path dumping implementation differences and font size differences.
Comment 1 Andras Becsi 2010-02-19 08:53:18 PST
Created attachment 49082 [details]
proposed patch
Comment 2 Antonio Gomes 2010-02-19 08:57:03 PST
LGTM
Comment 3 Kenneth Rohde Christiansen 2010-02-19 08:58:39 PST
Comment on attachment 49082 [details]
proposed patch

Looks good, but some comments


> +        [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
> +        for passing new tests and unskip the passing ones from the Skiplist.

It is called Skipped, not Skiplist


> +    QWebFrame* frame = m_page->mainFrame();
> +    if (frame)
> +        frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);
> +}

Why not do

if (QWebFrame* frame = m_page->mainFrame())
    frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);

?
Comment 4 Andras Becsi 2010-02-19 09:15:24 PST
Comment on attachment 49082 [details]
proposed patch

Updated patch committed in r55019. Closing bug.