WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
35149
Web Inspector: Popover x position is negative.
https://bugs.webkit.org/show_bug.cgi?id=35149
Summary
Web Inspector: Popover x position is negative.
Ilya Tikhonovsky
Reported
2010-02-19 05:33:59 PST
Popover x position is negative if anchor element has totalOffsetLeft = 0.
Attachments
Calculation for x position of Popover is fixed.
(1.30 KB, patch)
2010-02-19 05:36 PST
,
Ilya Tikhonovsky
pfeldman
: review-
Details
Formatted Diff
Diff
Popover x position calculation adjusted a bit
(1.33 KB, patch)
2010-02-19 05:55 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2010-02-19 05:36:37 PST
Created
attachment 49068
[details]
Calculation for x position of Popover is fixed.
Pavel Feldman
Comment 2
2010-02-19 05:51:54 PST
Comment on
attachment 49068
[details]
Calculation for x position of Popover is fixed. Should be Math.max(10, anchorBox.x) - borderWidth; (10 should be a const with a nice name such as "borderRadius")
Ilya Tikhonovsky
Comment 3
2010-02-19 05:55:07 PST
Created
attachment 49071
[details]
Popover x position calculation adjusted a bit
Pavel Feldman
Comment 4
2010-02-19 13:49:02 PST
Comment on
attachment 49071
[details]
Popover x position calculation adjusted a bit Would be nice to introduce const named borderRadius in place of 10 (you can do this in your subsequent change).
Pavel Feldman
Comment 5
2010-03-06 01:43:24 PST
Comment on
attachment 49071
[details]
Popover x position calculation adjusted a bit I think the change it now obsolete.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug