Bug 35143 - check-webkit-style ignores JavaScriptCore/qt/api directory
Summary: check-webkit-style ignores JavaScriptCore/qt/api directory
Status: RESOLVED DUPLICATE of bug 48322
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 03:46 PST by Jędrzej Nowacki
Modified: 2010-11-02 13:53 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-02-19 03:46:36 PST 
check-webkit-style ignores *.cpp and *.h files inside the JavaScriptCore/qt/ subdirectory which I believe is wrong. 

Message posted by WebKit Review Bot:
Ignoring "JavaScriptCore/qt/api/qscriptstring.cpp": this file is exempt from
the style guide.

An use case can be found in bug 34843.
Comment 1 David Levin 2010-11-02 13:47:22 PDT 
Is this a bug?

In WebKitTools/Scripts/webkitpy/style/checker.py, _SKIPPED_FILES_WITH_WARNING it sounds like this is because these are part of the qt api and it doesn't follow WebKit style.

If just a few rules should be omitted, this can be done in the section: _PATH_RULES_SPECIFIER
Comment 2 David Levin 2010-11-02 13:53:53 PDT 
I'll resolve this of a dup of a later bug since it has a patch attached.

*** This bug has been marked as a duplicate of bug 48322 ***