Bug 35134 - Crash when a plugin calls NPN_SetStatus(0)
Summary: Crash when a plugin calls NPN_SetStatus(0)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-02-18 16:19 PST by Alexey Proskuryakov
Modified: 2010-02-18 17:22 PST (History)
0 users

See Also:


Attachments
proposed fix (3.87 KB, patch)
2010-02-18 16:22 PST, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff
...and WebKitTools part (2.37 KB, patch)
2010-02-18 17:16 PST, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-02-18 16:19:01 PST
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2010-02-18 16:22:19 PST
Created attachment 49048 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2010-02-18 16:22:50 PST
<rdar://problem/7246280>
Comment 3 mitz 2010-02-18 16:24:46 PST
Comment on attachment 49048 [details]
proposed fix

> +            if (!postData)
> +                return NPERR_INVALID_PARAM;
>              RetainPtr<CFStringRef> bufString(AdoptCF, CFStringCreateWithCString(kCFAllocatorDefault, postData, kCFStringEncodingWindowsLatin1));
> -            if (!bufString)
> +            if (!postData)

Why this change?
Comment 4 Alexey Proskuryakov 2010-02-18 16:26:12 PST
Oops, copy/paste mistake.
Comment 5 Alexey Proskuryakov 2010-02-18 16:38:47 PST
Committed <http://trac.webkit.org/changeset/54993>.
Comment 6 Alexey Proskuryakov 2010-02-18 17:16:42 PST
Created attachment 49049 [details]
...and WebKitTools part
Comment 7 mitz 2010-02-18 17:18:41 PST
Comment on attachment 49049 [details]
...and WebKitTools part

> +    } else if (name == pluginMethodIdentifiers[ID_SET_STATUS]) {
> +        return testSetStatus(plugin, args, argCount, result);
>      }

No braces around one-line clause.
Comment 8 Alexey Proskuryakov 2010-02-18 17:22:08 PST
Committed WebKitTools part as <http://trac.webkit.org/changeset/54996>.