WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
35101
Calculation of transform in RenderLayer::paintLayer can be simplified
https://bugs.webkit.org/show_bug.cgi?id=35101
Summary
Calculation of transform in RenderLayer::paintLayer can be simplified
Steve Block
Reported
2010-02-18 08:55:37 PST
In RenderLayer::paintLayer, when calculating the transform to be applied, the following code is used ... TransformationMatrix transform; transform.translate(x, y); transform = layerTransform * transform; This can instead be achieved in a single step ... TransformationMatrix transform(layerTransform); transform.translateRight(x, y); This avoids most of the calculation in transform(), which is redundant as transform is initially the identity matrix.
Attachments
Patch
(1.25 KB, patch)
2010-02-18 09:03 PST
,
Steve Block
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Steve Block
Comment 1
2010-02-18 09:03:37 PST
Created
attachment 49021
[details]
Patch
Simon Fraser (smfr)
Comment 2
2010-02-19 17:14:52 PST
Comment on
attachment 49021
[details]
Patch r=me Please run some layout tests in pixel mode to check that this behavior is correct.
WebKit Commit Bot
Comment 3
2010-02-22 06:26:19 PST
Comment on
attachment 49021
[details]
Patch Clearing flags on attachment: 49021 Committed
r55081
: <
http://trac.webkit.org/changeset/55081
>
WebKit Commit Bot
Comment 4
2010-02-22 06:26:23 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug