Bug 35093 - [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
Summary: [Soup] loses information related to message flags when converting from/to Res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2010-02-18 05:56 PST by Gustavo Noronha (kov)
Modified: 2010-02-22 09:02 PST (History)
0 users

See Also:


Attachments
proposed fix (9.93 KB, patch)
2010-02-18 06:02 PST, Gustavo Noronha (kov)
gustavo: commit-queue-
Details | Formatted Diff | Diff
Refactor updating of ResourceResponse (4.18 KB, patch)
2010-02-19 10:09 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Fix the actual problem (8.07 KB, patch)
2010-02-19 10:10 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-02-18 05:56:53 PST
When creating a WebCore object from a SoupMessage, we are not storing the message flags anywhere, so they get lost, and are not restored when creating the message from the WebCore object. We need this so that apps can use the flags when they get the message from WebKitNetworkRequest.
Comment 1 Gustavo Noronha (kov) 2010-02-18 06:02:18 PST
Created attachment 49006 [details]
proposed fix

This is the WebKit piece of the puzzle to get information regarding SSL certs to Epiphany. Although this was the primary motivation, this is indeed a limitation of the backend in general, and has potential to be useful in other cases.
Comment 2 Gustavo Noronha (kov) 2010-02-19 10:09:42 PST
Created attachment 49086 [details]
Refactor updating of ResourceResponse
Comment 3 Gustavo Noronha (kov) 2010-02-19 10:10:19 PST
Created attachment 49087 [details]
Fix the actual problem

Patches split, as discussed by Jabber =).
Comment 4 Xan Lopez 2010-02-19 13:54:13 PST
Comment on attachment 49086 [details]
Refactor updating of ResourceResponse

The ChangeLog seems a bit... unorthodox. Otherwise looks fine.
Comment 5 Xan Lopez 2010-02-19 13:56:01 PST
Comment on attachment 49087 [details]
Fix the actual problem

LGTM.
Comment 6 Gustavo Noronha (kov) 2010-02-20 04:26:49 PST
Comment on attachment 49086 [details]
Refactor updating of ResourceResponse

Landed as r55046.
Comment 7 Gustavo Noronha (kov) 2010-02-20 04:37:38 PST
Comment on attachment 49087 [details]
Fix the actual problem

Landed as r55047.
Comment 8 Gustavo Noronha (kov) 2010-02-22 09:02:29 PST
Comment on attachment 49087 [details]
Fix the actual problem

I had to roll this out because it caused tests to fail, but I figured out the problem (I was failing to initialize m_soupFlags to 0 when constructing the objects), and got Xan to do an informal rubber stamp, and then relanded.