RESOLVED FIXED Bug 35091
style-queue should not complain about identifier names with underscores under WebKit/efl/ewk/ 
https://bugs.webkit.org/show_bug.cgi?id=35091
Summary style-queue should not complain about identifier names with underscores under...
Leandro Pereira
Reported 2010-02-18 05:13:47 PST
Our APIs use EFL style naming, so we need to use lower-cased, _-separated names there. An example of this happenning: https://webkit-commit-queue.appspot.com/results/283368
Attachments
Proposed patch (1.50 KB, patch)
2010-02-18 05:14 PST, Leandro Pereira 		hamaji: review-
DetailsFormatted DiffDiff
Proposed patch, with requested test case (2.17 KB, patch)
2010-02-18 07:30 PST, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2010-02-18 05:14:56 PST
Created attachment 49000 [details] Proposed patch
Shinichiro Hamaji
Comment 2 2010-02-18 06:31:43 PST
Comment on attachment 49000 [details] Proposed patch Looks good, but could you write a test case for this? The comment above _PATH_RULES_SPECIFIER points where you should modify. # Each string appearing in this nested list should have at least # one associated unit test assertion. These assertions are located, # for example, in the test_path_rules_specifier() unit test method of # checker_unittest.py. _PATH_RULES_SPECIFIER = [ r- for this reason.
Leandro Pereira
Comment 3 2010-02-18 07:30:52 PST
Created attachment 49012 [details] Proposed patch, with requested test case Requested changes. Note that this test will fail until WebKit/efl exists.
Shinichiro Hamaji
Comment 4 2010-02-18 18:38:35 PST
Thanks for adding the test case! > Note that this test will fail until WebKit/efl exists. Hmm... I thought this test doesn't check if the path exists. Also, the test seems to be passing. Will the test really fail? Otherwise, I'd like to land this patch as is. Thanks,
Shinichiro Hamaji
Comment 5 2010-02-18 23:32:02 PST
Comment on attachment 49012 [details] Proposed patch, with requested test case Looks good, but setting cq- until it turns out this won't break the test.
Leandro Pereira
Comment 6 2010-02-19 12:42:11 PST
(In reply to comment #4) > Thanks for adding the test case! > > > Note that this test will fail until WebKit/efl exists. > > Hmm... I thought this test doesn't check if the path exists. Also, the test > seems to be passing. Will the test really fail? Otherwise, I'd like to land > this patch as is. > Tested it here, it seems to pass. Sorry for the false alarm.
Shinichiro Hamaji
Comment 7 2010-02-19 17:49:06 PST
Comment on attachment 49012 [details] Proposed patch, with requested test case Thanks for checking!
WebKit Commit Bot
Comment 8 2010-02-19 18:08:44 PST
Comment on attachment 49012 [details] Proposed patch, with requested test case Clearing flags on attachment: 49012 Committed r55042: <http://trac.webkit.org/changeset/55042>
WebKit Commit Bot
Comment 9 2010-02-19 18:08:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.