Our APIs use EFL style naming, so we need to use lower-cased, _-separated names there. An example of this happenning: https://webkit-commit-queue.appspot.com/results/283368
Created attachment 49000 [details] Proposed patch
Comment on attachment 49000 [details] Proposed patch Looks good, but could you write a test case for this? The comment above _PATH_RULES_SPECIFIER points where you should modify. # Each string appearing in this nested list should have at least # one associated unit test assertion. These assertions are located, # for example, in the test_path_rules_specifier() unit test method of # checker_unittest.py. _PATH_RULES_SPECIFIER = [ r- for this reason.
Created attachment 49012 [details] Proposed patch, with requested test case Requested changes. Note that this test will fail until WebKit/efl exists.
Thanks for adding the test case! > Note that this test will fail until WebKit/efl exists. Hmm... I thought this test doesn't check if the path exists. Also, the test seems to be passing. Will the test really fail? Otherwise, I'd like to land this patch as is. Thanks,
Comment on attachment 49012 [details] Proposed patch, with requested test case Looks good, but setting cq- until it turns out this won't break the test.
(In reply to comment #4) > Thanks for adding the test case! > > > Note that this test will fail until WebKit/efl exists. > > Hmm... I thought this test doesn't check if the path exists. Also, the test > seems to be passing. Will the test really fail? Otherwise, I'd like to land > this patch as is. > Tested it here, it seems to pass. Sorry for the false alarm.
Comment on attachment 49012 [details] Proposed patch, with requested test case Thanks for checking!
Comment on attachment 49012 [details] Proposed patch, with requested test case Clearing flags on attachment: 49012 Committed r55042: <http://trac.webkit.org/changeset/55042>
All reviewed patches have been landed. Closing bug.