The previous patch to this file was broken (sorry). First of all, the conversion from UTF8 was accidentally removed. Second, for empty strings, we need to point the implementation at StringImpl::empty().
Created attachment 48988 [details] Fixes conversion from BString to String This patch fixes the conversion for real. Patch is again r54932 and does not depend on any other patches.
BTW, the include sorting is correct, the style bot doesn't handle this case.
Comment on attachment 48988 [details] Fixes conversion from BString to String Changing bstring to string makes this more confusing to my eyes. Otherwise this looks sane.
Comment on attachment 48988 [details] Fixes conversion from BString to String Clearing flags on attachment: 48988 Committed r55154: <http://trac.webkit.org/changeset/55154>
All reviewed patches have been landed. Closing bug.