Bug 35069 – Forward declaration of TimingFunction as a class in GraphicsLayer.h results in compile warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Vangelis Kokkevis]

GraphicsLayer.h contains a forward declaration of TimingFunction as:

class TimingFunction

However, TimingFunction is defined as a struct in:

WebCore\Platform\animation\TimingFunction.h

The MSVC compiler issues a warning about this. 

Proposed change: Change the forward declaration to read:

struct TimingFunction

[Vangelis Kokkevis]

Created attachment 48961 [details]
Proposed patch

[WebKit Review Bot]

Attachment 48961 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 48961 [details]
Proposed patch

Remove the tabs in the Changelog, and the OOPS line.
r=me

[Vangelis Kokkevis]

Created attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line

[Simon Fraser (smfr)]

Comment on attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line

r=me

[WebKit Commit Bot]

Comment on attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line

Clearing flags on attachment: 49024

Committed r54987: <http://trac.webkit.org/changeset/54987>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.