Bug 35069 - Forward declaration of TimingFunction as a class in GraphicsLayer.h results in compile warnings
Summary: Forward declaration of TimingFunction as a class in GraphicsLayer.h results i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 19:21 PST by Vangelis Kokkevis
Modified: 2010-02-18 14:08 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch (1.23 KB, patch)
2010-02-17 19:28 PST, Vangelis Kokkevis
simon.fraser: review+
Details | Formatted Diff | Diff
Patch #2: Removed tabs from changelog and OOPS line (1.23 KB, patch)
2010-02-18 09:30 PST, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-02-17 19:21:20 PST
GraphicsLayer.h contains a forward declaration of TimingFunction as:

class TimingFunction

However, TimingFunction is defined as a struct in:

WebCore\Platform\animation\TimingFunction.h

The MSVC compiler issues a warning about this. 

Proposed change: Change the forward declaration to read:

struct TimingFunction
Comment 1 Vangelis Kokkevis 2010-02-17 19:28:35 PST
Created attachment 48961 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-02-17 19:29:09 PST
Attachment 48961 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2010-02-17 20:16:13 PST
Comment on attachment 48961 [details]
Proposed patch

Remove the tabs in the Changelog, and the OOPS line.
r=me
Comment 4 Vangelis Kokkevis 2010-02-18 09:30:43 PST
Created attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line
Comment 5 Simon Fraser (smfr) 2010-02-18 09:35:35 PST
Comment on attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line

r=me
Comment 6 WebKit Commit Bot 2010-02-18 14:08:26 PST
Comment on attachment 49024 [details]
Patch #2: Removed tabs from changelog and OOPS line

Clearing flags on attachment: 49024

Committed r54987: <http://trac.webkit.org/changeset/54987>
Comment 7 WebKit Commit Bot 2010-02-18 14:08:31 PST
All reviewed patches have been landed.  Closing bug.