Bug 35058 - Chromium: WebDocument should provide access to the title.
Summary: Chromium: WebDocument should provide access to the title.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jay Campan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 14:29 PST by Jay Campan
Modified: 2010-02-18 01:27 PST (History)
2 users (show)

See Also:


Attachments
Exposing the title in WebDocument. (1.62 KB, patch)
2010-02-17 14:35 PST, Jay Campan
ariya.hidayat: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Adding bug to ChangeLog (1.69 KB, patch)
2010-02-17 17:02 PST, Jay Campan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Campan 2010-02-17 14:29:40 PST
WebDocument should have a title() method that returns the document title.
Comment 1 Jay Campan 2010-02-17 14:35:51 PST
Created attachment 48939 [details]
Exposing the title in WebDocument.
Comment 2 Ariya Hidayat 2010-02-17 16:43:22 PST
Comment on attachment 48939 [details]
Exposing the title in WebDocument.

LGTM.
Comment 3 Darin Fisher (:fishd, Google) 2010-02-17 16:53:18 PST
Comment on attachment 48939 [details]
Exposing the title in WebDocument.

> Index: WebKit/chromium/ChangeLog

> +        Reviewed by NOBODY (OOPS!).
> +
> +        Exposing the title in WebDocument.
> +

^^^ The ChangeLog should have a bug link.  Otherwise, LGTM.  Please upload a revised patch for the commit queue :)

-Darin
Comment 4 Jay Campan 2010-02-17 17:02:57 PST
Created attachment 48948 [details]
Adding bug to ChangeLog
Comment 5 Adam Barth 2010-02-18 00:18:24 PST
Comment on attachment 48948 [details]
Adding bug to ChangeLog

Forwarding fishd's R+.
Comment 6 WebKit Commit Bot 2010-02-18 01:27:09 PST
Comment on attachment 48948 [details]
Adding bug to ChangeLog

Clearing flags on attachment: 48948

Committed r54948: <http://trac.webkit.org/changeset/54948>
Comment 7 WebKit Commit Bot 2010-02-18 01:27:14 PST
All reviewed patches have been landed.  Closing bug.