Bug 35057 – Set viewport to canvas size upon context creation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

Per the latest draft of the WebGL specification, the OpenGL viewport must be set to (0, 0, canvas.width, canvas.height) upon context creation. This is a change in behavior compared to the recently incorporated fix https://bugs.webkit.org/show_bug.cgi?id=34766 .

[Zhenyao Mo]

Created attachment 49455 [details]
patch

[Kenneth Russell]

Looks good to me, though I'm not sure the text

Test: fast/canvas/webgl/gl-get-calls.html

in WebCore/ChangeLog is appropriate, since it matches the format prepare-ChangeLog uses when a new test is added. Perhaps say instead "Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html".

[Zhenyao Mo]

Created attachment 49459 [details]
revised patch: changed the log text according to Ken's advice

[David Levin]

Comment on attachment 49459 [details]
revised patch: changed the log text according to Ken's advice

> Index: WebCore/ChangeLog
> [phone]  Zhenyao Mo  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Set viewport to canvas size upon context creation
> +        https://bugs.webkit.org/show_bug.cgi?id=35057
> +
> +        Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html
> +
> +        * html/canvas/WebGLRenderingContext.cpp:
> +        (WebCore::WebGLRenderingContext::WebGLRenderingContext):

Ideally there are per file comments explaining the change. For example,

    (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport siz


> Index: LayoutTests/ChangeLog
> [phone]  Zhenyao Mo  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Need a short description and bug URL (OOPS!)

Do you see what I see? :)



> +
> +        * fast/canvas/webgl/bug-32888.html:

Per file comments would be nice. For example "Removed call to set the viewport size since this is done when the context is created."

(You may say "Ditto." if the comment for a file is the same as the last comment.

> +        * fast/canvas/webgl/gl-get-calls-expected.txt:

A comment for this file would have a *very short* explanation of why the result changed.

> +        * fast/canvas/webgl/gl-get-calls.html:
> +        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
> +        * fast/canvas/webgl/tex-sub-image-2d.html:
> +        * fast/canvas/webgl/texImage2DImageDataTest.html:
> +        * fast/canvas/webgl/triangle.html:
> +        * fast/canvas/webgl/viewport-unchanged-upon-resize.html:
> +

[Zhenyao Mo]

Created attachment 49507 [details]
revised patch: added per change description in log files.

[WebKit Commit Bot]

Comment on attachment 49507 [details]
revised patch: added per change description in log files. 

Clearing flags on attachment: 49507

Committed r55282: <http://trac.webkit.org/changeset/55282>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.