SingleTestThread and TestShellThread should share more code
Created attachment 48933 [details] Patch
I did this because I was looking at adding support for dumping out the "list of prior test" for any test which fails. Many of our current failures are caused by test interactions. Knowing which tests were run leading up to a specific failure will help us narrow down those failures.
Comment on attachment 48933 [details] Patch > +# FIXME: Why do we need a separate class to handle --singly? Can't we just use many > +# TestShellThreads and only feed each one test? > +class SingleTestThread(TestThread): Actually, now that I look more closely at this, I'm not even sure we need that. What's weird right now is that SingleTestThread is spawned from TestShellThread. It's not clear to me why _run_test_singly doesn't just kill testshell/drt and then start it up again. Anyways, it's a FIXME. Otherwise, LGTM.
please reformat this to stay within 80 columns as per the PEP 8 style guide :) I think this patch is safe, but is basically rearranging ugly code. You put a FIXME in somewhere to just collapse the two classes, and I agree that that would probably be a better way to fix this. Is there some reason you're not doing that as part of this patch? Also, I believe this --run-singly option is only used by the valgrind bots (presumably to help ensure clean test runs); you might put a comment into the code somewhere to indicate this, so people can understand why we need this option at all.
Comment on attachment 48933 [details] Patch I'm mostly relying on Ojan and Dirk here, but this looks reasonable to me. Please fix the pep8 nits before landing. (We really need to integrate pep8 into the style elf.)
Attachment 48933 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Wow. I doubt this still even applies.
Comment on attachment 48933 [details] Patch We'll see what the cq says.
Comment on attachment 48933 [details] Patch Rejecting patch 48933 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth', '--force']" exit_code: 1 Last 500 characters of output: itpy/layout_tests/layout_package/test_shell_thread.py Hunk #1 FAILED at 48. Hunk #2 succeeded at 62 (offset 3 lines). Hunk #3 succeeded at 143 (offset 3 lines). Hunk #4 FAILED at 156. Hunk #5 succeeded at 180 (offset 3 lines). Hunk #6 succeeded at 276 with fuzz 1 (offset 3 lines). Hunk #7 succeeded at 287 (offset 3 lines). Hunk #8 succeeded at 412 (offset 3 lines). 2 out of 8 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py.rej Full output: http://webkit-commit-queue.appspot.com/results/1203028
This patch is too out of date to save. I'll redo this at a later date.