RESOLVED WONTFIX 35054
[gtk] windowless plugins don't get button mask on mouse motion events 
https://bugs.webkit.org/show_bug.cgi?id=35054
Summary [gtk] windowless plugins don't get button mask on mouse motion events
Brian Tarricone
Reported 2010-02-17 13:36:23 PST
I imagine this is also true of the Qt backend, but I'm working on gtk, so... Currently the windowless plugin code doesn't set Button1MotionMask (or Button2MotionMask or Button3MotionMask) when sending XMotionEvents to the plugin. Will attach patch after I get a bug # for the changelog...
Attachments
pass button mask to windowless plugins in XMotionEvent (1.51 KB, patch)
2010-02-17 13:40 PST, Brian Tarricone 		eric: review-
DetailsFormatted DiffDiff
attempt at test (doesn't work) (6.94 KB, patch)
2010-05-16 17:45 PDT, Brian Tarricone 		no flags
DetailsFormatted DiffDiff
the test html/js (1.41 KB, text/plain)
2010-05-16 17:47 PDT, Brian Tarricone 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brian Tarricone
Comment 1 2010-02-17 13:40:18 PST
Created attachment 48932 [details] pass button mask to windowless plugins in XMotionEvent ... and here's our fix.
Eric Seidel (no email)
Comment 2 2010-02-17 15:41:09 PST
Comment on attachment 48932 [details] pass button mask to windowless plugins in XMotionEvent How do we test this? It should be possible using the test plugin included with DumpRenderTree.
Brian Tarricone
Comment 3 2010-02-17 16:20:04 PST
(In reply to comment #2) > (From update of attachment 48932 [details]) > How do we test this? It should be possible using the test plugin included with > DumpRenderTree. For me, I have an in-house NPAPI plugin I'm using (which is how I came across the bug). In the NPAPI event handler, you can check that XMotionEvent::state contains Button1MotionMask when button one is held down (and similar for buttons 2 and 3). Not sure if the DumpRenderTree test plugin (I didn't even know it had one!) can easily be modified to do th same thing.
Holger Freyther
Comment 5 2010-03-09 20:05:02 PST
I agree with Eric... using the EventSender and the test plugin we should be able to test this automatically.
Eric Seidel (no email)
Comment 6 2010-03-15 15:47:03 PDT
Comment on attachment 48932 [details] pass button mask to windowless plugins in XMotionEvent OK. How do we test this? TestPlugin.cpp + window.eventSender should be able to do it, no?
Brian Tarricone
Comment 7 2010-05-16 17:45:24 PDT
Created attachment 56202 [details] attempt at test (doesn't work) Here's my first attempt at a test using eventSender and the test npapi plugin, but I can't get it to work. I verified that the DumpRenderTree window gets events, but eventSender doesn't seem to be working at all. Any ideas? Is it known to work on linux/gtk?
Brian Tarricone
Comment 8 2010-05-16 17:47:51 PDT
Created attachment 56203 [details] the test html/js Whoops, forgot the actual test file too.
Martin Robinson
Comment 9 2010-10-12 16:59:05 PDT
EventSender should be working on WebKitGTK+. Are you still looking into this?
Martin Robinson
Comment 10 2014-04-08 16:11:54 PDT
The original patch was for WebKit1, which is going to be removed soon. I'm going to close this bug for now, but please reopen if it's still an issue with WebKit2.
Note You need to log in before you can comment on or make changes to this bug.