Bug 35025 - Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML
Summary: Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 03:17 PST by Alexander Pavlov (apavlov)
Modified: 2010-03-16 09:47 PDT (History)
8 users (show)

See Also:


Attachments
Test Case (128 bytes, application/xhtml+xml)
2010-02-17 03:17 PST, Alexander Pavlov (apavlov)
no flags Details
[PATCH] Proposed fix. (9.60 KB, patch)
2010-03-16 06:35 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-02-17 03:17:38 PST
Created attachment 48882 [details]
Test Case

1. Bring up the Web Inspector for the attached Test Case (XHTML page).
2. In the Elements panel (note that the top-level node is not expanded), make the <img> or <script> elements visible.
3. Click either of the <img> or <script> elements.

In the Console, you will see a red crossed circle followed by "Error dispatching: getStyles" (or "Error dispatching: getInlineStyle").
The Styles sidebar pane is empty, and the Properties pane does not show the full elements hierarchy (HTMLImgElement or HTMLScriptElement are not displayed)
Comment 1 Pavel Feldman 2010-03-16 06:35:15 PDT
Created attachment 50786 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2010-03-16 06:58:16 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/MetricsSidebarPane.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
Committed r56059
Comment 3 Adam Barth 2010-03-16 09:05:25 PDT
This appears to have broken the tree:

$ ./WebKitTools/Scripts/webkit-patch what-broke
Leopard Intel Release (Tests)     : FAIL (blame-list: [56059])
Leopard Intel Debug (Tests)       : FAIL (blame-list: [56059])
SnowLeopard Intel Release (Tests) : FAIL (blame-list: [56059])
Comment 4 Pavel Feldman 2010-03-16 09:47:29 PDT
(In reply to comment #3)
> This appears to have broken the tree:
> 
> $ ./WebKitTools/Scripts/webkit-patch what-broke
> Leopard Intel Release (Tests)     : FAIL (blame-list: [56059])
> Leopard Intel Debug (Tests)       : FAIL (blame-list: [56059])
> SnowLeopard Intel Release (Tests) : FAIL (blame-list: [56059])

Should have been fixed by r56067