Bug 35024 – [GTK/Qt] Black text on black buttons using a dark theme

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

1. Set a dark Qt theme
2. go to http://bugs.webkit.org/ for instance

The buttons are unreadable, screenshot here :
http://www.kirikoo.net/images/14Anonyme-20100217-110456.png

Fix :
I suggest forcing the font color from the Qt theme to the button's font color.
Using dark themes, this will ensure white text on dark buttons, and using bright themes, black text on bright buttons.

No one will never have anymore problems after that, whatever his Qt theme. :)

Nota : the problem is the same using Webkit GTK

This is a regression. With Qt 4.5 everything was fine :

http://www.kirikoo.net/images/14Anonyme-20100217-111736.png

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit

    http://trac.webkit.org/wiki/QtWebKitBugs#Component

[Robert Hogan]

I can reproduce this with QtLauncher.

(In reply to comment #2)
>   - The 'QtWebKit' component should be used for bugs/features in the public
> QtWebKit API layer, not to signify that the bug is specific to the Qt port of
> WebKit

Like the problem is the same wth GTK, I posted here, but I should have posted twice in Qt and GTK.

[Olivier Tilloy]

I reported bug #37779 to track this specific issue in the GTK port.

[Jan Erik Hanssen]

Created attachment 78226 [details]
Patch

Implement the same for Qt as added to GTK in bug 37779. Does this need a test case?

[Andreas Kling]

Comment on attachment 78226 [details]
Patch

Awesome, r=me

[WebKit Commit Bot]

Comment on attachment 78226 [details]
Patch

Clearing flags on attachment: 78226

Committed r75273: <http://trac.webkit.org/changeset/75273>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.