Bug 35017 - Remove some warnings seen when building Qt
Summary: Remove some warnings seen when building Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 19:51 PST by Julien Chaffraix
Modified: 2010-02-17 09:49 PST (History)
2 users (show)

See Also:


Attachments
Proposed fix - add some checks and refactor the command testing logic (2.30 KB, patch)
2010-02-16 19:54 PST, Julien Chaffraix
jchaffraix: commit-queue-
Details | Formatted Diff | Diff
Proposed fix - add some checks and refactor the command testing logic (2.30 KB, patch)
2010-02-16 20:02 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2010-02-16 19:51:07 PST
Using a newly installed ubuntu install without the proper tools leads to several errors / warnings in build-webkit.
Comment 1 Julien Chaffraix 2010-02-16 19:54:39 PST
Created attachment 48855 [details]
Proposed fix - add some checks and refactor the command testing logic
Comment 2 WebKit Review Bot 2010-02-16 19:59:11 PST
Attachment 48855 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/Scripts/webkitdirs.pm:620:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Julien Chaffraix 2010-02-16 20:02:27 PST
Created attachment 48858 [details]
 Proposed fix - add some checks and refactor the command testing logic

A tab sneaked into this change, same patch without it.
Comment 4 Ariya Hidayat 2010-02-17 09:29:53 PST
Comment on attachment 48858 [details]
 Proposed fix - add some checks and refactor the command testing logic

LGTM.
Comment 5 WebKit Commit Bot 2010-02-17 09:49:51 PST
Comment on attachment 48858 [details]
 Proposed fix - add some checks and refactor the command testing logic

Clearing flags on attachment: 48858

Committed r54899: <http://trac.webkit.org/changeset/54899>
Comment 6 WebKit Commit Bot 2010-02-17 09:49:55 PST
All reviewed patches have been landed.  Closing bug.