RESOLVED FIXED Bug 35017
Remove some warnings seen when building Qt 
https://bugs.webkit.org/show_bug.cgi?id=35017
Summary Remove some warnings seen when building Qt
Julien Chaffraix
Reported 2010-02-16 19:51:07 PST
Using a newly installed ubuntu install without the proper tools leads to several errors / warnings in build-webkit.
Attachments
Proposed fix - add some checks and refactor the command testing logic (2.30 KB, patch)
2010-02-16 19:54 PST, Julien Chaffraix 		jchaffraix: commit-queue-
DetailsFormatted DiffDiff
Proposed fix - add some checks and refactor the command testing logic (2.30 KB, patch)
2010-02-16 20:02 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2010-02-16 19:54:39 PST
Created attachment 48855 [details] Proposed fix - add some checks and refactor the command testing logic
WebKit Review Bot
Comment 2 2010-02-16 19:59:11 PST
Attachment 48855 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitdirs.pm:620: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style.
Julien Chaffraix
Comment 3 2010-02-16 20:02:27 PST
Created attachment 48858 [details] Proposed fix - add some checks and refactor the command testing logic A tab sneaked into this change, same patch without it.
Ariya Hidayat
Comment 4 2010-02-17 09:29:53 PST
Comment on attachment 48858 [details] Proposed fix - add some checks and refactor the command testing logic LGTM.
WebKit Commit Bot
Comment 5 2010-02-17 09:49:51 PST
Comment on attachment 48858 [details] Proposed fix - add some checks and refactor the command testing logic Clearing flags on attachment: 48858 Committed r54899: <http://trac.webkit.org/changeset/54899>
WebKit Commit Bot
Comment 6 2010-02-17 09:49:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.