Bug 35004 - [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
Summary: [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-02-16 15:38 PST by Laszlo Gombos
Modified: 2010-02-19 06:34 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (2.63 KB, patch)
2010-02-16 15:49 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-02-16 15:38:24 PST
DumpRenderTree/qt/DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up and enables all HTML5 persistent data. All the other calls for setting the persistent path or enabling the persistent feature are redundant and potential source of problems (as it was with bug 34713).
Comment 1 Laszlo Gombos 2010-02-16 15:49:20 PST
Created attachment 48845 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-02-17 16:39:13 PST
Comment on attachment 48845 [details]
proposed patch

OK.
Comment 3 WebKit Commit Bot 2010-02-19 06:34:44 PST
Comment on attachment 48845 [details]
proposed patch

Clearing flags on attachment: 48845

Committed r55013: <http://trac.webkit.org/changeset/55013>
Comment 4 WebKit Commit Bot 2010-02-19 06:34:48 PST
All reviewed patches have been landed.  Closing bug.