Bug 35001 - websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
Summary: websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromiu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Fumitoshi Ukai
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2010-02-16 15:06 PST by Eric Seidel (no email)
Modified: 2010-02-17 18:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2010-02-16 17:56 PST, Fumitoshi Ukai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-02-16 15:06:48 PST
websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests

The WebSocket server that run-chromium-webkit-tests is running seems to be just returning the contents of the .pl file instead of actually executing the perl.
Comment 1 Dirk Pranke 2010-02-16 15:56:12 PST
We probably need to merge http://codereview.chromium.org/565027 upstream (the fix for https://bugs.webkit.org/show_bug.cgi?id=34289).
Comment 2 Fumitoshi Ukai 2010-02-16 17:56:33 PST
Created attachment 48852 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-02-16 18:15:05 PST
Comment on attachment 48852 [details]
Patch

That seems like the wrong path.
Comment 4 Fumitoshi Ukai 2010-02-16 18:23:23 PST
(In reply to comment #3)
> (From update of attachment 48852 [details])
> That seems like the wrong path.

What do you mean?
A path for -x is the relative path to document root, and this path is the same 
used in WebKitTools/Scripts/run-webkit-websocketserver.
Comment 5 Fumitoshi Ukai 2010-02-16 18:33:30 PST
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 48852 [details] [details])
> > That seems like the wrong path.
> 
> What do you mean?
> A path for -x is the relative path to document root, and this path is the same 
> used in WebKitTools/Scripts/run-webkit-websocketserver.

Note that current chromium would fail this test.
need http://codereview.chromium.org/601077 to pass the test.
Comment 6 Eric Seidel (no email) 2010-02-17 11:49:28 PST
Comment on attachment 48852 [details]
Patch

LGTM.
Comment 7 Eric Seidel (no email) 2010-02-17 14:23:50 PST
Attachment 48852 [details] was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit.
Comment 8 Fumitoshi Ukai 2010-02-17 18:19:53 PST
Committed r54920: <http://trac.webkit.org/changeset/54920>