RESOLVED FIXED Bug 35000
[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes 
https://bugs.webkit.org/show_bug.cgi?id=35000
Summary [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes
James Hawkins
Reported 2010-02-16 14:54:54 PST
releaseRef releases the original pointer without decreasing the reference count, and the base class constructor increases the reference count, leading to a leak. Attachment will follow.
Attachments
[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. (2.65 KB, patch)
2010-02-16 14:55 PST, James Hawkins 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. (2.71 KB, patch)
2010-02-16 16:14 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-02-16 14:55:51 PST
Created attachment 48837 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes.
Darin Fisher (:fishd, Google)
Comment 2 2010-02-16 14:59:33 PST
Comment on attachment 48837 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. > Index: WebKit/chromium/ChangeLog ... > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base > + classes. releaseRef releases the original pointer without decreasing > + the reference count, and the base class constructor increases the > + reference count, leading to a leak. > + > + * src/WebDocument.cpp: Oops, this ChangeLog needs a bug link. Otherwise, LGTM
James Hawkins
Comment 3 2010-02-16 16:14:46 PST
Created attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Added bug link.
Eric Seidel (no email)
Comment 4 2010-02-16 16:47:21 PST
Comment on attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Yes, this is clearly correct. Thank you!
WebKit Commit Bot
Comment 5 2010-02-16 19:21:55 PST
Comment on attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Clearing flags on attachment: 48846 Committed r54861: <http://trac.webkit.org/changeset/54861>
WebKit Commit Bot
Comment 6 2010-02-16 19:22:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.