releaseRef releases the original pointer without decreasing the reference count, and the base class constructor increases the reference count, leading to a leak. Attachment will follow.
Created attachment 48837 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes.
Comment on attachment 48837 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. > Index: WebKit/chromium/ChangeLog ... > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base > + classes. releaseRef releases the original pointer without decreasing > + the reference count, and the base class constructor increases the > + reference count, leading to a leak. > + > + * src/WebDocument.cpp: Oops, this ChangeLog needs a bug link. Otherwise, LGTM
Created attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Added bug link.
Comment on attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Yes, this is clearly correct. Thank you!
Comment on attachment 48846 [details] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes. Clearing flags on attachment: 48846 Committed r54861: <http://trac.webkit.org/changeset/54861>
All reviewed patches have been landed. Closing bug.