Bug 34997 - Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
Summary: Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 14:12 PST by Adam Barth
Modified: 2010-02-24 16:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2010-02-16 14:14 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2010-02-20 23:19 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (4.58 KB, patch)
2010-02-20 23:45 PST, Adam Barth 		fishd: review+
fishd: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-02-16 14:12:28 PST 
Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
Comment 1 Adam Barth 2010-02-16 14:14:05 PST 
Created attachment 48831 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-16 14:17:05 PST 
Attachment 48831 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/271553
Comment 3 WebKit Review Bot 2010-02-16 14:24:24 PST 
Attachment 48831 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/271555
Comment 4 WebKit Review Bot 2010-02-16 14:42:28 PST 
Attachment 48831 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/271577
Comment 5 Adam Barth 2010-02-16 18:05:54 PST 
Comment on attachment 48831 [details]
Patch

Oops.  Will try again.
Comment 6 Adam Barth 2010-02-20 23:19:44 PST 
Created attachment 49142 [details]
Patch
Comment 7 Adam Barth 2010-02-20 23:20:40 PST 
This time I actually tried it.  :)
Comment 8 WebKit Review Bot 2010-02-20 23:25:34 PST 
Attachment 49142 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/296159
Comment 9 Adam Barth 2010-02-20 23:45:05 PST 
Created attachment 49143 [details]
Patch
Comment 10 Eric Seidel (no email) 2010-02-24 14:56:29 PST 
Comment on attachment 49143 [details]
Patch

Why not just add a new method on Loader which does this check?

Seems slightly silly to have to copy/paste this large line.
Comment 11 Adam Barth 2010-02-24 15:49:02 PST 
> Why not just add a new method on Loader which does this check?

Sounds like a good idea.  Will do in a followup patch.
Comment 12 Peter Kasting 2010-02-24 16:17:25 PST 
Landed in r55206.