WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34968
Web Inspector: let search iterate over views in Resources and keep the view in Scripts.
https://bugs.webkit.org/show_bug.cgi?id=34968
Summary
Web Inspector: let search iterate over views in Resources and keep the view i...
Pavel Feldman
Reported
2010-02-15 23:10:39 PST
Rationale: While in resources panel, there is a chance user is iterating over all occurrences. He has a hint with number of results within each view, he has a visual representation of the selected resource, so jumping to the next does not become a big surprise. At the same time, while in scripts panel, user is interested in local search. He is likely to expect view to be the same and search to cycle within. Before the change we were in a weird state of doing different things when search back and forward (due to something I introduced). Even before that, search was iterating over views on scripts panel that was unacceptable.
Attachments
[PATCH] Proposed change.
(5.08 KB, patch)
2010-02-15 23:12 PST
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-02-15 23:12:51 PST
Created
attachment 48790
[details]
[PATCH] Proposed change.
Timothy Hatcher
Comment 2
2010-02-16 00:36:57 PST
Good points.
Pavel Feldman
Comment 3
2010-02-16 02:10:32 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/inspector.js Committed
r54812
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug