Bug 34965 - With hardware acceleration turned off, video frames never display if poster image is specified
Summary: With hardware acceleration turned off, video frames never display if poster i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-02-15 19:49 PST by Simon Fraser (smfr)
Modified: 2010-02-16 14:04 PST (History)
1 user (show)

See Also:


Attachments
Testcase (BWO image and video) (529 bytes, text/html)
2010-02-15 19:49 PST, Simon Fraser (smfr)
no flags Details
Patch (4.98 KB, patch)
2010-02-15 20:03 PST, Simon Fraser (smfr)
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-02-15 19:49:07 PST
Created attachment 48785 [details]
Testcase (BWO image and video)

When accelerated compositing is disabled, a video element with a poster image doesn't start showing the video once frames become available.
Comment 1 Simon Fraser (smfr) 2010-02-15 19:49:30 PST
<rdar://problem/7651526>
Comment 2 Simon Fraser (smfr) 2010-02-15 20:03:10 PST
Created attachment 48786 [details]
Patch
Comment 3 Eric Carlson 2010-02-15 20:27:59 PST
Comment on attachment 48786 [details]
Patch

Because updatePosterImage is now called for every video frame, it might make sense to change HTMLVideoElement::updatePosterImage so hasAvailableVideoFrame() is called before poster().isEmpty() as I assume it is cheaper as the later requires an allocation. 

r=me either way
Comment 4 Simon Fraser (smfr) 2010-02-16 14:04:58 PST
http://trac.webkit.org/changeset/54828