Bug 34954 - PlatformContextSkia limits SVG stroke width
Summary: PlatformContextSkia limits SVG stroke width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-15 12:25 PST by Bryan Yeung
Modified: 2010-02-16 19:05 PST (History)
2 users (show)

See Also:


Attachments
remove bounds and add a layout test for the regression (21.35 KB, patch)
2010-02-15 12:35 PST, Bryan Yeung
zimmermann: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard (21.41 KB, patch)
2010-02-16 13:18 PST, Bryan Yeung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Yeung 2010-02-15 12:25:14 PST
WebCore/platform/graphics/skia/PlatformContextSkia.cpp imposes a very low limit (512) on stroke width.  This causes some SVG images to render incorrectly.
Comment 1 Bryan Yeung 2010-02-15 12:35:47 PST
Created attachment 48768 [details]
remove bounds and add a layout test for the regression
Comment 2 Nikolas Zimmermann 2010-02-15 17:37:40 PST
Comment on attachment 48768 [details]
remove bounds and add a layout test for the regression

r=me, looks fine.
Comment 3 WebKit Commit Bot 2010-02-15 18:49:50 PST
Comment on attachment 48768 [details]
remove bounds and add a layout test for the regression

Rejecting patch 48768 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12164 test cases.
svg/custom/stroke-width-large.svg -> failed

Exiting early after 1 failures. 9784 tests run.
211.53s total testing time

9783 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/268930
Comment 4 Bryan Yeung 2010-02-16 13:18:36 PST
Created attachment 48819 [details]
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard
Comment 5 Nikolas Zimmermann 2010-02-16 16:23:09 PST
Comment on attachment 48819 [details]
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard

Let's retry :-)
Comment 6 WebKit Commit Bot 2010-02-16 19:05:49 PST
Comment on attachment 48819 [details]
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard

Clearing flags on attachment: 48819

Committed r54859: <http://trac.webkit.org/changeset/54859>
Comment 7 WebKit Commit Bot 2010-02-16 19:05:54 PST
All reviewed patches have been landed.  Closing bug.