Bug 34945 - Improve API for form validation message strings
Summary: Improve API for form validation message strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-15 08:23 PST by Kent Tamura
Modified: 2010-11-14 21:40 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (44.96 KB, patch)
2010-02-15 08:30 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Proposed patch (50.14 KB, patch)
2010-02-15 08:37 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Proposed patch (rev.3) (50.14 KB, patch)
2010-03-08 23:09 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch (28.95 KB, patch)
2010-11-10 23:28 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 5 (30.95 KB, patch)
2010-11-14 20:53 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-02-15 08:23:55 PST
Improve form validation messages.
Comment 1 Kent Tamura 2010-02-15 08:30:25 PST
Created attachment 48754 [details]
Proposed patch
Comment 2 Kent Tamura 2010-02-15 08:37:08 PST
Created attachment 48756 [details]
Proposed patch
Comment 3 Kent Tamura 2010-03-08 23:09:50 PST
Created attachment 50278 [details]
Proposed patch (rev.3)

Upload the same patch again to kick EWS.
Comment 4 Kent Tamura 2010-03-08 23:39:36 PST
(In reply to comment #3)
> Created an attachment (id=50278) [details]
> Proposed patch (rev.3)
> 
> Upload the same patch again to kick EWS.

Oh, I understand.  svn-apply doesn't support Git binary diff.
Comment 5 Eric Seidel (no email) 2010-03-25 01:35:04 PDT
It does not support delta binary diffs, only literal binary diffs. :)
Comment 6 Adam Barth 2010-06-20 08:46:47 PDT
Comment on attachment 50278 [details]
Proposed patch (rev.3)

This patch has been up for review for too long.  Who's the right person to review this patch?  Why has it stalled out?  I don't know whether the new messages are better or worse than the old messages.  Is there a spec for this stuff?  Something has broken down here.

LayoutTests/fast/forms/script-tests/validationMessage.js:16
 +           "'The value does not match to a character restriction for this field.'");
Where do these messages come from?  Are they speced somewhere?
Comment 7 Kent Tamura 2010-11-10 23:15:29 PST
I have changed my mind.
I won't change the existing form validation messages, and just add some additional parameters to validationMessage*() functions in order that a port can improve the messages.
Comment 8 Kent Tamura 2010-11-10 23:28:38 PST
Created attachment 73583 [details]
Patch
Comment 9 Dimitri Glazkov (Google) 2010-11-12 12:35:09 PST
Comment on attachment 73583 [details]
Patch

ok.
Comment 10 Kent Tamura 2010-11-14 20:53:15 PST
Created attachment 73873 [details]
Patch 5
Comment 11 Kent Tamura 2010-11-14 20:54:48 PST
(In reply to comment #9)
> (From update of attachment 73583 [details])
> ok.

Thank you for r+.  But I have updated the patch.
I added a dedicated function for <input type=email multiple>. It should show a different message than <input type=email>.
Comment 12 Dimitri Glazkov (Google) 2010-11-14 21:06:25 PST
Comment on attachment 73873 [details]
Patch 5

ok.
Comment 13 Kent Tamura 2010-11-14 21:40:15 PST
Comment on attachment 73873 [details]
Patch 5

Clearing flags on attachment: 73873

Committed r71996: <http://trac.webkit.org/changeset/71996>
Comment 14 Kent Tamura 2010-11-14 21:40:24 PST
All reviewed patches have been landed.  Closing bug.