Bug 34940 – [Gtk] testwebview does not work when called with absolute path

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[arno.]

Hi, when trying to run testwebviow from a random directory (ie: with an absolute path), it fails with following error: 

15:04 127 ~ % ~/webkit/WebKit/WebKitBuild/Release/Programs/unittests/testwebview
**
ERROR:../../WebKit/gtk/tests/testwebview.c:244:main: assertion failed: (!g_str_equal(getcwd(path_name, PATH_MAX), "/"))
zsh: abort      ~/webkit/WebKit/WebKitBuild/Release/Programs/unittests/testwebview

other testes in unittests succeed when run with absolute path.

[arno.]

Created attachment 48749 [details]
patch v1

[Gustavo Noronha (kov)]

Comment on attachment 48749 [details]
patch v1

That looks good. I'm afraid at least one more test needs this fix, though, and it would be good to have this split to a function in an utils file. Would you mind applying the fix to the other file, and potentially do this refactoring? It's OK if you just apply the fix to the other files, but the refactoring would rock =).

 236     if (g_path_is_absolute (argv[0])) {
 237         g_chdir (g_path_get_dirname (argv[0]));

These spaces before the ( are wrong, r- for this style problem.

[arno.]

Created attachment 49090 [details]
patch v2

Here is an updated version.

[arno.]

Created attachment 49091 [details]
patch v2.2

updated patch: last one did not mention added tests/test_utils.c in WebKit/gtk/ChangeLog

[Gustavo Noronha (kov)]

Comment on attachment 49091 [details]
patch v2.2

 30 extern int testutils_relative_chdir(const gchar*, const gchar*);

Adding a header, and a proper signature would be better, plus, you should add the bug URL, and its description to the changelog:

 8         Need a short description and bug URL (OOPS!)

Otherwise, this patch is a good step forward, thanks for taking the time to refactor this! One more round to fix up these two small issues, and I'll r+ it.

[arno.]

Created attachment 49222 [details]
patch v2.3

updated patch

[Gustavo Noronha (kov)]

Comment on attachment 49222 [details]
patch v2.3

Better, thanks!

[WebKit Commit Bot]

Comment on attachment 49222 [details]
patch v2.3

Clearing flags on attachment: 49222

Committed r55173: <http://trac.webkit.org/changeset/55173>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.