Bug 34935 – Web Inspector: REGRESSION: long URLs can cause a horizontal scrollbar in source view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

Created attachment 48743 [details]
Bug

A long URL can cause a horizontal scrollbar. We need to break URLs and long words more aggressively (by character).

You can see this on Daring Fireball's main resource with a small Inspector window. See screenshot.

[Patrick Mueller]

I thought we were going to move towards not wrapping lines to begin with.  In which case horizontal scrollbars are not a bad thing.  In fact, from the screen shot, it looks like "not wrapping" is now on, somehow.  Yay!

[Timothy Hatcher]

Right now it is a mix, wrapping to the longest line.

We need to pick fulll wrap or no wrap.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/inspector/syntax-highlight-html-expected.txt
	A	LayoutTests/inspector/syntax-highlight-html.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.js
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.re2js
Committed r54780

[Pavel Feldman]

Closed wrong bug...

[Pavel Feldman]

I'd like to disable line wrapping instead of fixing this one. It just looks easier than making links wrapping work. Yes, it'll make line numbers potentially off the screen, but we can fix it later.

[Pavel Feldman]

Created attachment 48767 [details]
[PATCH] Proposed change.

[Timothy Hatcher]

Comment on attachment 48767 [details]
[PATCH] Proposed change.

Should it be white-space: no-wrap;?

[Pavel Feldman]

(In reply to comment #7)
> (From update of attachment 48767 [details])
> Should it be white-space: no-wrap;?

Sorry, this is out of context. Do you mean main editor element's style? I thought it should be pre. Or do you mean line's one? It does not need to be at all I guess. (Why not r+)?

[Timothy Hatcher]

Comment on attachment 48767 [details]
[PATCH] Proposed change.

white-space: pre will cause \n to make a newline. white-space: no-wrap will no allow any new lines.

So I think you want no-wrap in both places you use pre. Try it out.

[Pavel Feldman]

(In reply to comment #9)
> (From update of attachment 48767 [details])
> white-space: pre will cause \n to make a newline. white-space: no-wrap will no
> allow any new lines.
> 
> So I think you want no-wrap in both places you use pre. Try it out.

It collapses whitespace...

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TextViewer.js
	M	WebCore/inspector/front-end/textViewer.css
	M	WebCore/inspector/front-end/utilities.js
Committed r54813

[Timothy Hatcher]

Good point… forgot about that.