Bug 34920 – [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Emilio Pozuelo Monfort]

Hi,

WebKit built fine on GNU/Hurd until 1.1.17. However some release after that has introduced PATH_MAX in a couple of tests. PATH_MAX is not guaranteed to be defined and thus shouldn't be used unconditionally for portability reasons.

I've prepared a patch to avoid using PATH_MAX to let WebKit build on GNU/Hurd again. It uses dynamic allocation instead of fixed size buffers.

[Emilio Pozuelo Monfort]

Created attachment 48703 [details]
Avoid using PATH_MAX for portability reasons

The patch is against 1.1.20 and builds fine, so since the patch is for the test suite, the tests should be fine :)

[Gustavo Noronha (kov)]

Comment on attachment 48703 [details]
Avoid using PATH_MAX for portability reasons

Patch looks sane, can you add a ChangeLog entry to WebKit/gtk/ChangeLog, and repost, please? =)

[Emilio Pozuelo Monfort]

Created attachment 48730 [details]
Avoid using PATH_MAX for portability reasons

Now with a ChangeLog entry. Patch against current git.

I haven't built the tests in git, should I? If so, what's the best way to do it?

[Gustavo Noronha (kov)]

Comment on attachment 48730 [details]
Avoid using PATH_MAX for portability reasons

Setting the review flag, since Emilio forgot it.

[Gustavo Noronha (kov)]

Comment on attachment 48730 [details]
Avoid using PATH_MAX for portability reasons

Thanks!

[WebKit Commit Bot]

Comment on attachment 48730 [details]
Avoid using PATH_MAX for portability reasons

Clearing flags on attachment: 48730

Committed r54779: <http://trac.webkit.org/changeset/54779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.