Bug 34897 - [Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
Summary: [Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-12 09:46 PST by Jeremy Orlow
Modified: 2010-02-12 12:31 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.83 KB, patch)
2010-02-12 10:00 PST, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (4.55 KB, patch)
2010-02-12 11:19 PST, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (4.55 KB, patch)
2010-02-12 11:40 PST, Jeremy Orlow
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-02-12 09:46:07 PST
[Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
Comment 1 Jeremy Orlow 2010-02-12 10:00:19 PST
Created attachment 48650 [details]
Patch
Comment 2 Jeremy Orlow 2010-02-12 10:01:43 PST
Other half of the review you were looking at, Darin.
Comment 3 Darin Fisher (:fishd, Google) 2010-02-12 10:36:27 PST
Comment on attachment 48650 [details]
Patch

R=me, but it seems like it would be nice to extend the DOMStorageSetItemResult enum to the WebKit API.  Or, at least it would also be nice to rename quotaException to blockedByQuota.
Comment 4 Jeremy Orlow 2010-02-12 10:45:22 PST
(In reply to comment #3)
> (From update of attachment 48650 [details])
> R=me, but it seems like it would be nice to extend the DOMStorageSetItemResult
> enum to the WebKit API.  Or, at least it would also be nice to rename
> quotaException to blockedByQuota.

How would we do that?  Move it entirely into the WebKit layer and have Chromium refer to that enum or have 2 of them and translate?
Comment 5 Darin Fisher (:fishd, Google) 2010-02-12 10:48:51 PST
It is fine to use WebKit API defined enums in Chromium code.  That might be best if you want to do that.
Comment 6 Jeremy Orlow 2010-02-12 11:19:29 PST
Created attachment 48652 [details]
Patch
Comment 7 Jeremy Orlow 2010-02-12 11:40:28 PST
Created attachment 48654 [details]
Patch