Bug 34877 - Rename underscored identifiers in CSSParser.cpp
Summary: Rename underscored identifiers in CSSParser.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuzo Fujishima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 21:46 PST by Yuzo Fujishima
Modified: 2010-02-11 22:42 PST (History)
4 users (show)

See Also:


Attachments
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (35.49 KB, patch)
2010-02-11 21:56 PST, Yuzo Fujishima
hamaji: review+
Details | Formatted Diff | Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (36.35 KB, patch)
2010-02-11 21:57 PST, Yuzo Fujishima
no flags Details | Formatted Diff | Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (36.08 KB, patch)
2010-02-11 22:04 PST, Yuzo Fujishima
no flags Details | Formatted Diff | Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (40.91 KB, patch)
2010-02-11 22:12 PST, Yuzo Fujishima
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2010-02-11 21:46:20 PST
WebCore/css/CSSParser.cpp contains underscored identifiers. They should be renamed.

WebCore/css/CSSParser.cpp:574:  valid_primitive is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/css/CSSParser.cpp:1079:  is_valid is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

Note:
yy_* are handled by https://bugs.webkit.org/show_bug.cgi?id=34067 and https://bugs.webkit.org/show_bug.cgi?id=34787.
Comment 1 Yuzo Fujishima 2010-02-11 21:56:29 PST
Created attachment 48622 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Comment 2 Yuzo Fujishima 2010-02-11 21:57:50 PST
Created attachment 48623 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Comment 3 Shinichiro Hamaji 2010-02-11 21:58:27 PST
Comment on attachment 48622 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.

Looks great!
Comment 4 WebKit Review Bot 2010-02-11 22:00:42 PST
Attachment 48623 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/css/CSSParser.cpp:776:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:971:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:986:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:994:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1010:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1019:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1034:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1053:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1246:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1270:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1280:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1286:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1461:  Missing spaces around |  [whitespace/operators] [3]
Total errors found: 13


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Shinichiro Hamaji 2010-02-11 22:01:45 PST
Comment on attachment 48623 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.

> +        WebCore/css/CSSParser.cpp:574:  valid_primitive is incorrectly named. Don't use
> +        underscores in your identifier names.  [readability/naming] [4]
> +        WebCore/css/CSSParser.cpp:1079:  is_valid is incorrectly named. Don't use
> +        underscores in your identifier names.  [readability/naming] [4]

I'm not sure if we need these 4 lines in ChangeLog.

> +        No new tests are required.

It would be better to say the reason why we don't need new tests.
Comment 6 Yuzo Fujishima 2010-02-11 22:04:39 PST
Created attachment 48624 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Comment 7 WebKit Review Bot 2010-02-11 22:06:13 PST
Attachment 48624 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/css/CSSParser.cpp:776:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:971:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:986:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:994:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1010:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1019:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1034:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1053:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1246:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1270:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1280:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1286:  Missing spaces around |  [whitespace/operators] [3]
WebCore/css/CSSParser.cpp:1461:  Missing spaces around |  [whitespace/operators] [3]
Total errors found: 13


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Yuzo Fujishima 2010-02-11 22:12:33 PST
Created attachment 48626 [details]
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Comment 9 Yuzo Fujishima 2010-02-11 22:18:30 PST
Fixed the Change log and new style issues that surfaced after fixing underscored names.

Can you take another look?
Comment 10 Yuzo Fujishima 2010-02-11 22:42:32 PST
Committed r54703: <http://trac.webkit.org/changeset/54703>