WebCore/css/CSSParser.cpp contains underscored identifiers. They should be renamed. WebCore/css/CSSParser.cpp:574: valid_primitive is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/css/CSSParser.cpp:1079: is_valid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Note: yy_* are handled by https://bugs.webkit.org/show_bug.cgi?id=34067 and https://bugs.webkit.org/show_bug.cgi?id=34787.
Created attachment 48622 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Created attachment 48623 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Comment on attachment 48622 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp. Looks great!
Attachment 48623 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSParser.cpp:776: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:971: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:986: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:994: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1010: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1019: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1034: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1053: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1246: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1270: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1280: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1286: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1461: Missing spaces around | [whitespace/operators] [3] Total errors found: 13 If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 48623 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp. > + WebCore/css/CSSParser.cpp:574: valid_primitive is incorrectly named. Don't use > + underscores in your identifier names. [readability/naming] [4] > + WebCore/css/CSSParser.cpp:1079: is_valid is incorrectly named. Don't use > + underscores in your identifier names. [readability/naming] [4] I'm not sure if we need these 4 lines in ChangeLog. > + No new tests are required. It would be better to say the reason why we don't need new tests.
Created attachment 48624 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Attachment 48624 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSParser.cpp:776: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:971: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:986: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:994: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1010: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1019: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1034: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1053: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1246: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1270: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1280: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1286: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1461: Missing spaces around | [whitespace/operators] [3] Total errors found: 13 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 48626 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.
Fixed the Change log and new style issues that surfaced after fixing underscored names. Can you take another look?
Committed r54703: <http://trac.webkit.org/changeset/54703>