Bug 34872 - Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
Summary: Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 19:17 PST by Joseph Pecoraro
Modified: 2010-02-11 21:15 PST (History)
7 users (show)

See Also:


Attachments
[PATCH] Fix Tab Backwards (3.29 KB, patch)
2010-02-11 19:25 PST, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-02-11 19:17:40 PST
When editing style rules, you can tab forward and backwards in most cases. However, you cannot tab backwards from a new blank property. This should be doable.
Comment 1 Joseph Pecoraro 2010-02-11 19:25:25 PST
Created attachment 48611 [details]
[PATCH] Fix Tab Backwards

Tabbing backwards from a new property was not triggering the afterUpdate handler. Normal behavior is to call update, check for an existing _afterUpdate, trigger that and remove it. In this special case, update() doesn't need to be called, but the afterUpdate handler should be triggered.

This patch also carries some trailing whitespace cases and style updates in the same file.
Comment 2 Timothy Hatcher 2010-02-11 19:53:01 PST
Comment on attachment 48611 [details]
[PATCH] Fix Tab Backwards

Welcome back!
Comment 3 Joseph Pecoraro 2010-02-11 21:01:57 PST
Committed r54700
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/StylesSidebarPane.js
r54700 = 610848abe2470362352c6d1e42902e2ac51134a3 (trunk)

(In reply to comment #2)
> Welcome back!

Glad to be back. I've been focusing on learning some iPhone Dev., to prepare for the job. But I figured I'd take a look down the list to see what I could pick at for a few hours. I hope I can get more into the swing of things =)