Bug 34867 - DatabaseAuthorizer should allow the use of CREATE/DROP VIRTUAL TABLE
Summary: DatabaseAuthorizer should allow the use of CREATE/DROP VIRTUAL TABLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 17:46 PST by Dumitru Daniliuc
Modified: 2010-02-19 19:10 PST (History)
3 users (show)

See Also:


Attachments
patch (9.72 KB, patch)
2010-02-11 18:29 PST, Dumitru Daniliuc
no flags Details | Formatted Diff | Diff
patch (1.96 KB, patch)
2010-02-16 17:08 PST, Dumitru Daniliuc
dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-02-11 17:46:31 PST
Chromium needs virtual tables in order to use FTS. I'm not sure why CREATE/DROP VIRTUAL TABLE have been disabled in WebKit since forever, but it seems to me like these instructions don't pose any security threat and should be allowed.
Comment 1 Dumitru Daniliuc 2010-02-11 18:29:49 PST
Created attachment 48602 [details]
patch
Comment 2 Dumitru Daniliuc 2010-02-16 17:08:17 PST
Created attachment 48849 [details]
patch

Oops, uploaded the wrong patch.
Comment 3 Michael Nordman 2010-02-17 12:31:51 PST
If there is no reason to disallow them, why filter on moduleName? Maybe just denyBasedOnTableName(tableName) and not test the 'moduleName' at all.
Comment 4 Chris Evans 2010-02-17 14:17:37 PST
Interesting. If there's no user demand for direct creation of virtual tables, I'd be tempted to play it safe, and restrict them to internal usage by fts2.
Comment 5 Dimitri Glazkov (Google) 2010-02-18 13:21:28 PST
Comment on attachment 48849 [details]
patch

ok.
Comment 6 Dumitru Daniliuc 2010-02-19 19:10:06 PST
Landed as r54990.