RESOLVED FIXED 34853
Web Inspector: restore highlighting animation, bring back keyboard navigation, beautify search results.
https://bugs.webkit.org/show_bug.cgi?id=34853
Summary Web Inspector: restore highlighting animation, bring back keyboard navigation...
Pavel Feldman
Reported 2010-02-11 10:52:36 PST
Fixing nits.
Attachments
[PATCH] Proposed change. (2.33 KB, patch)
2010-02-11 10:53 PST, Pavel Feldman
oliver: review+
Pavel Feldman
Comment 1 2010-02-11 10:53:57 PST
Created attachment 48583 [details] [PATCH] Proposed change.
Oliver Hunt
Comment 2 2010-02-11 14:02:37 PST
Comment on attachment 48583 [details] [PATCH] Proposed change. r=me
Timothy Hatcher
Comment 3 2010-02-11 14:15:54 PST
Comment on attachment 48583 [details] [PATCH] Proposed change. Why not fade to transparent?
Timothy Hatcher
Comment 4 2010-02-11 14:16:36 PST
Comment on attachment 48583 [details] [PATCH] Proposed change. > + -webkit-animation: 'fadeout' 2s 0s; Can you use double quotes here, to match the other quotes in the file.
Pavel Feldman
Comment 5 2010-02-12 05:17:12 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextViewer.js M WebCore/inspector/front-end/textViewer.css Committed r54720 (In reply to comment #4) > (From update of attachment 48583 [details]) > > + -webkit-animation: 'fadeout' 2s 0s; > > Can you use double quotes here, to match the other quotes in the file. Done. (In reply to comment #3) > (From update of attachment 48583 [details]) > Why not fade to transparent? I just took the old SourceFrame code...
Note You need to log in before you can comment on or make changes to this bug.