Bug 34853 - Web Inspector: restore highlighting animation, bring back keyboard navigation, beautify search results.
Summary: Web Inspector: restore highlighting animation, bring back keyboard navigation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 10:52 PST by Pavel Feldman
Modified: 2010-02-12 05:17 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed change. (2.33 KB, patch)
2010-02-11 10:53 PST, Pavel Feldman
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-02-11 10:52:36 PST
Fixing nits.
Comment 1 Pavel Feldman 2010-02-11 10:53:57 PST
Created attachment 48583 [details]
[PATCH] Proposed change.
Comment 2 Oliver Hunt 2010-02-11 14:02:37 PST
Comment on attachment 48583 [details]
[PATCH] Proposed change.

r=me
Comment 3 Timothy Hatcher 2010-02-11 14:15:54 PST
Comment on attachment 48583 [details]
[PATCH] Proposed change.

Why not fade to transparent?
Comment 4 Timothy Hatcher 2010-02-11 14:16:36 PST
Comment on attachment 48583 [details]
[PATCH] Proposed change.

> +    -webkit-animation: 'fadeout' 2s 0s;

Can you use double quotes here, to match the other quotes in the file.
Comment 5 Pavel Feldman 2010-02-12 05:17:12 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TextViewer.js
	M	WebCore/inspector/front-end/textViewer.css
Committed r54720

(In reply to comment #4)
> (From update of attachment 48583 [details])
> > +    -webkit-animation: 'fadeout' 2s 0s;
> 
> Can you use double quotes here, to match the other quotes in the file.

Done.

(In reply to comment #3)
> (From update of attachment 48583 [details])
> Why not fade to transparent?

I just took the old SourceFrame code...